Skip to content

fix: Preserve client navigation for deferred props. #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 1 commit into from
Jul 6, 2026
Merged

fix: Preserve client navigation for deferred props. #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/void/src/pages/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,8 @@ export async function handlePageGet(
return pageJsonResponse(c, pageObj);
}
// Stream NDJSON: first line is PageObject, subsequent lines are deferred groups
c.header('X-VoidPages', 'true');
c.header('Vary', 'X-VoidPages');
return streamDeferredResponse(
JSON.stringify(pageObj) + '\n',
deferredMap,
Expand Down
20 changes: 20 additions & 0 deletions packages/void/test/unit/pages-protocol.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,6 +794,26 @@ describe('handlePageMutation', () => {
});

describe('handlePageGet with deferred props', () => {
it('SPA — marks deferred NDJSON responses as Void Pages responses', async () => {
const c = await createTestContext('GET', '/dashboard', {
headers: { 'x-voidpages': 'true' },
});

const response = await handlePageGet(
() => ({
usage: defer(() => Promise.resolve({ requests: 100 })),
}),
undefined,
c,
'dashboard',
mockRenderFn,
mockGetAssetTags,
);

expect(response.headers.get('X-VoidPages')).toBe('true');
expect(response.headers.get('Vary')).toBe('X-VoidPages');
});

it('SPA — streams NDJSON with immediate props first, then deferred', async () => {
const c = await createTestContext('GET', '/dashboard', {
headers: { 'x-voidpages': 'true' },
Expand Down