Repository navigation
test: fix flaky tests - #24
Merged
Merged
Conversation
- Use IF NOT EXISTS for SQLite ADD COLUMN in auth migrations (D1 supports it since SQLite 3.35+), matching PostgreSQL behavior - Pre-resolve better-auth client subpaths in Vite SSR dep optimizer via resolve.alias to prevent lazy discovery causing disruptive program reloads on first auth page load with cold cache - Update projects-command test to expect staging.void.app URLs after default auth env was switched to staging in f2a8d68 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c57dc9b104
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The first request to a cold Vite dev server triggers SSR dependency optimization (drizzle-orm, vue, hono, etc.), causing multiple program reloads that exceed the 10s Playwright timeout. Add a warmup fetch in beforeAll to let the reloads settle before tests run. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The include list caused Vite to attempt pre-bundling the aliased better-auth modules, which involves reading package.json. Since the aliases point to raw .mjs files, Vite tried to JSON-parse JavaScript source, crashing the dev server on CI. The resolve.alias alone is sufficient — it resolves bare specifiers to absolute file paths, preventing lazy SSR dep discovery without needing pre-bundling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d02b80467
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
SQLite does not support IF NOT EXISTS on ALTER TABLE ADD COLUMN — only PostgreSQL does. The SQLite path correctly relies on the check-then-act pattern (PRAGMA table_info → skip existing columns) in applySqliteAuthMigrations(). Revert to the original behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Brooooooklyn
changed the title
fengmk2
approved these changes
Mar 20, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
When defineAuth() received a plain object (not a function), resolveUserConfig returned the user config directly, silently discarding all security defaults — secret, baseURL, basePath, database, and trustedOrigins. The object form now shallow-merges user overrides on top of defaults, matching the safe behavior of the no-config path while preserving the function form's full control. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/auth-integration-issues
branch
from
March 20, 2026 10:44
ee1bfd0 to
e7833c6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7833c615c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Brooooooklyn
added a commit
that referenced
this pull request
Apr 17, 2026
Even after #24 the CI is still flaky for some cases. I've bumped the timeouts. Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
The dashboard will be rewritten — skip deploying it in both staging and production pipelines. Also reverts the esmExternalRequirePlugin workaround from #23 since it's no longer needed. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Brooooooklyn
added a commit
that referenced
this pull request
Oct 26, 2026
Fixes #565 ## Problem With auth on, `vp dev` aliases five better-auth subpaths to files in Void's own copy of better-auth. Each alias used a **string** `find`, and in Vite a string `find` also matches every deeper path: ``` alias find 'better-auth/client' → …/better-auth/dist/client/index.mjs import 'better-auth/client' → …/dist/client/index.mjs ✓ import 'better-auth/client/plugins' → …/dist/client/index.mjs/plugins ✗ (no such file) ``` So any app that passes a Better Auth client plugin (`adminClient()`, `organizationClient()`, …) to `createAuthClient` broke in dev: - the client failed with `Failed to resolve import "better-auth/client/plugins"`; - SSR returned 500 (`No such module …`). `vp build` adds no alias, so it was fine. ## Fix Each `find` is now an anchored RegExp, `^better-auth/<sub>$`. Vite's alias API has only two kinds of `find`: a string, which also matches deeper paths, or a RegExp. So a RegExp is the only way to get an exact match. The repo already does the same (`{ find: /^void$/ }` in `cli/wrapper.ts`). ``` before (string) after (exact) better-auth/client Void's copy ✓ Void's copy ✓ (unchanged) better-auth/react|vue|svelte|solid Void's copy ✓ Void's copy ✓ (unchanged) better-auth/client/plugins broken path ✗ normal resolution ✓ ``` The five exact ids get the same replacement in every Vite step that reads `resolve.alias`: - the alias plugin; - `vite:pre-alias`; - SSR externalization; - the dependency optimizer. So the cold-cache reload protection from #24 (the reason the aliases exist) is kept. ## Checks - **New test** in `plugin-routing.test.ts`. It starts a real Vite dev server with auth on and resolves: - `better-auth/client` and `/react` from an app file, which has no better-auth of its own. They resolve only through the aliases, to Void's copy. - `better-auth/client/plugins` from inside the package. It resolves to `dist/client/plugins/index.mjs`. - **Mutation check:** the test fails with the old string `find` and with no aliases at all. - **Scratch app from the issue:** a React pages app, auth on, `adminClient()` from `better-auth/client/plugins`, cold cache, `vp dev`. ``` before after SSR GET / 500 No such module 200, authClient.admin.listUsers is a function client module 500 Failed to resolve 200 ``` - `void` typecheck, lint and fmt pass. Affected tests (`vp run test`, 508 files) pass. ## Not changed here - **`client/plugins` is not pinned to Void's copy.** The issue mentions this as optional. Without it, the user's own better-auth provides `client/plugins`, as in `vp build`, and Vite discovers it like any other dependency. That costs one optimizer reload on the first cold-cache page that imports it. Pinning would point the import at Void's better-auth version instead of the one the app installed. That's a product decision, so I left it out. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes Better Auth option resolution to merge user-provided object configs with defaults and adjusts Vite dev SSR resolution via new
better-auth/*aliases, which could subtly affect auth/runtime behavior in dev and production. Test changes are low risk but these runtime/config changes warrant verification across different auth configurations and package managers (e.g., pnpm strict mode).Overview
Improves Better Auth configuration handling by merging default options with object-style user configs (in both schema generation and runtime), instead of replacing defaults entirely.
Reduces auth-related dev-server reloads by adding a Vite
serve-only alias setup forbetter-authclient subpaths so SSR can resolve them without relying on hoisted dependencies.Stabilizes integration tests by warming up the Vite dev server before running Playwright flows and updates the
project listCLI test expectations to use*.staging.void.appURLs.Written by Cursor Bugbot for commit e7833c6. This will update automatically on new commits. Configure here.