Skip to content

docs: correct Deploy-on-GitHub connect flow + deploy-token TTL - #234

Merged
Brooooooklyn merged 1 commit into
mainfrom
docs/deploy-on-github-accuracy
Jun 29, 2026
Merged

Brooooooklyn merged 1 commit into
mainfrom
docs/deploy-on-github-accuracy

Conversation

@Brooooooklyn

@Brooooooklyn Brooooooklyn commented Jun 26, 2026 •

Copy link
Copy Markdown
Member

What

Two small accuracy fixes to the public Deploy-on-GitHub docs, verified against the current implementation:

  • docs/guide/deployment.md — the GitHub Actions repo is connected with void github connect <project> --repo <owner/repo> --executor github_actions, not "the Void dashboard" (there is no dashboard connect flow). Added that this path requires the github_actions executor — the default container executor 401s the OIDC exchange. Also clarified the scoped deploy token TTL is plan-sized (~15 min on free, capped ~60 min), not a flat 15 minutes.
  • docs/reference/cli.md — same connect-via-CLI correction in the void init --github explainer.

Why

Verified against source:

  • auth-oidc.ts rejects any non-github_actions connection with 401 (connection.build_executor !== 'github_actions'), and getGitHubActionsConnectionsByRepo filters on build_executor = 'github_actions'.
  • Deploy-token TTL is sized to the owner plan's buildTimeoutMinutes, hard-capped at 60 min (deployTokenTtlSecondsForBuildMinutes); 15 min is only the default.

Scope

Docs only — no code or behavior change.

🤖 Generated with Claude Code


Note

Low Risk
Markdown-only documentation changes with no code or runtime behavior impact.

Overview
Docs-only updates to GitHub Actions deploy guidance in docs/guide/deployment.md and docs/reference/cli.md.

The docs now say repo authorization happens via void github connect <project> --repo <owner/repo> --executor github_actions, not a Void dashboard connect step. They also state that the OIDC workflow requires the github_actions build executor (the default container executor is incompatible).

The OIDC exchange description no longer implies a fixed ~15 minute deploy token; it notes plan-based TTL (~15 minutes on free, up to ~60 minutes on higher plans).

Reviewed by Cursor Bugbot for commit 24de741. Bugbot is set up for automated code reviews on this repo. Configure here.

The GitHub Actions deploy path is connected via `void github connect
<project> --repo <owner/repo> --executor github_actions`, not "the Void
dashboard" — there is no dashboard connect flow, and the default
`container` executor 401s the OIDC exchange (auth-oidc.ts gates on
build_executor === 'github_actions'). Also clarify the scoped deploy
token TTL is plan-sized (~15 min on free, capped ~60 min), not a flat
15 minutes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Brooooooklyn
Brooooooklyn merged commit 80ea1d1 into main Jun 29, 2026
7 checks passed
@Brooooooklyn
Brooooooklyn deleted the docs/deploy-on-github-accuracy branch June 29, 2026 09:47
cpojer pushed a commit that referenced this pull request Sep 11, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant