Skip to content

chore: switch default auth env to staging - #23

Merged
Brooooooklyn merged 1 commit into
mainfrom
03-18-chore_switch_default_auth_env_to_staging
Mar 18, 2026
Merged

Brooooooklyn merged 1 commit into
mainfrom
03-18-chore_switch_default_auth_env_to_staging

Conversation

@Brooooooklyn

@Brooooooklyn Brooooooklyn commented Mar 18, 2026 •

Copy link
Copy Markdown
Member

Note

Medium Risk
Changes the CLI’s environment selection so staging becomes the default unless explicitly disabled, which can redirect logins/tokens/API calls to the wrong environment if users rely on the previous prod default or STAGING env var.

Overview
Updates CLI auth environment handling so staging mode is now the default: isStagingMode() returns false only when config explicitly sets staging: false, and setStagingMode(false) now persists that explicit opt-out.

This removes the prior behavior of enabling staging via staging: true or the STAGING environment variable, shifting environment selection to be config-driven with staging-by-default semantics.

Written by Cursor Bugbot for commit 95ecb33. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95ecb331ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/void/src/cli/auth.ts
Comment thread packages/void/src/cli/auth.ts
@Brooooooklyn
Brooooooklyn merged commit f2a8d68 into main Mar 18, 2026
7 of 8 checks passed
@Brooooooklyn
Brooooooklyn deleted the 03-18-chore_switch_default_auth_env_to_staging branch March 18, 2026 13:53
cpojer pushed a commit that referenced this pull request Sep 11, 2026
The `pg` package uses CJS `require("events")`, `require("crypto")`, etc.
When bundled by Rolldown for a CF Worker, these become `__require()` calls
that fail at runtime because Workers don't expose `require()` (even with
`nodejs_compat`). The `@cloudflare/vite-plugin`'s built-in
`esmExternalRequirePlugin` should handle this but wasn't applying to the
`void_dashboard` environment correctly.

Add `esmExternalRequirePlugin` explicitly in the dashboard's vite config
targeting the `void_dashboard` environment, transforming
`require("events")` → `import * as m from "events"`.

Also seeds drizzle migration tracking lessons for future reference.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
cpojer pushed a commit that referenced this pull request Sep 11, 2026
The dashboard will be rewritten — skip deploying it in both staging
and production pipelines. Also reverts the esmExternalRequirePlugin
workaround from #23 since it's no longer needed.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants