Skip to content

fix(router): don't crash dev response when X-Void-Routing trace is non-ASCII #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brooooooklyn merged 2 commits into from
Jun 30, 2026
Merged

fix(router): don't crash dev response when X-Void-Routing trace is non-ASCII #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e42a5af
fix(router): don't crash dev response when X-Void-Routing trace is no…
hyfdev Jun 18, 2026
7ec2704
Merge branch 'main' into fix/dev-routing-trace-non-ascii
Brooooooklyn Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/void/src/router/compile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,8 @@ export function compileRouteTable(
lines.push('function __voidAnnotateRouting(response, trace) {');
lines.push(' if (!__VOID_DEV_ROUTING || !response) return response;');
lines.push(' const headers = new Headers(response.headers);');
lines.push(' headers.set("X-Void-Routing", trace);');
// Guard the set: a non-ASCII trace value throws, and must not crash the dev response.
lines.push(' try { headers.set("X-Void-Routing", trace); } catch { return response; }');
lines.push(
' return new Response(response.body, { status: response.status, statusText: response.statusText, headers });',
);
Expand Down
8 changes: 8 additions & 0 deletions packages/void/test/unit/compile.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1800,6 +1800,14 @@ describe('X-Void-Routing dev trace header', () => {
expect(code).toContain('try { c.res.headers.set("X-Void-Routing", "pass-through"); } catch {}');
});

it('guards the __voidAnnotateRouting trace header set with try/catch', () => {
const code = compileWith({ dev: true });
// A non-ASCII trace value throws on header set; the guard must swallow it.
expect(code).toContain(
'try { headers.set("X-Void-Routing", trace); } catch { return response; }',
);
});

it('emits __VOID_DEV_ROUTING=false and strips origin fields in prod', () => {
const code = compileWith({ dev: false });
expect(code).toContain('const __VOID_DEV_ROUTING = false;');
Expand Down