Repository navigation
feat(pages): support client-only page rendering - #212
Merged
Merged
Conversation
✅ Deploy Preview for staging-void-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
TheAlexLichter
marked this pull request as ready for review
May 25, 2026 03:55
cpojer
approved these changes
May 25, 2026
Member
|
If you wanna do one more pass, I think this is worth sending to your agent: |
Member
Author
|
Forwarding 😛 |
TheAlexLichter
force-pushed
the
pages-ssr-opt-out
branch
from
May 25, 2026 09:30
6d05f87 to
cd7f9c6
Compare
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
#212) * feat(api): add configurable workflow_path column to github_connections Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(plan): SDD plan for configurable deploy-workflow path (0010 addendum) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(api): persist workflow_path in github connection create/update helpers Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(api): accept + validate workflow_path on github connect/update routes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(api): pin OIDC deploy token to per-connection workflow_path Move the workflow-path gate from a hardcoded global constant to the selected connection's workflow_path, checked after connection selection. Preserves the anti-spoof workflowPathForRepo behavior and the deploy-oracle protection. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(api): cover per-connection workflow_path pin + setter validation OIDC: custom path mints, custom path rejects the scaffolded default, and two projects on one repo pin their own workflows. Also adds repositoryId to the pre-existing other.yml/spoof rejection tests so they reach the (now post-lookup) workflow gate instead of short-circuiting at connection lookup. Routes: POST/PATCH accept a valid path, default when omitted, and 400 on a path outside .github/workflows/ or containing '..'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(api): make workflow_path change atomic (revoke in-flight builds + lock-recheck) workflow_path is the OIDC anti-oracle gate, but was not treated like the sibling trust-config fields branch/executor: a change neither revoked in-flight builds nor was re-validated under the connection lock. Two gaps, both asymmetric with branch: - github.ts PATCH now terminalizes in-flight github_actions builds when workflow_path changes (their deploy token stays valid while active, so a build authorized under the OLD pin could keep publishing). Container builds don't use the workflow gate and are left running. - createGithubActionsBuildWithinLimit re-reads workflow_path under the same FOR UPDATE lock it already uses for branch and rejects with a new 'workflow-mismatch' outcome when the token's workflow no longer matches the current pin — closing the check(snapshot)->lock TOCTOU. auth-oidc passes the matched workflow path in and maps the outcome to 409. Regression tests: PATCH cancels in-flight github_actions builds (container untouched); createGithubActionsBuildWithinLimit returns workflow-mismatch when the pin diverged. Addresses the high-severity finding from the adversarial review of the configurable deploy-workflow-path feature. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(plan): note atomic workflow_path change (0010 addendum) Record the post-review semantics: a workflow_path pin change revokes in-flight github_actions builds and is re-validated under the connection lock (mirroring branch/executor), and the CLI fails closed if the server doesn't echo the pin. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: bump framework submodule to configurable deploy-workflow-path CLI Points the platform at the framework branch tip carrying the `--workflow` flag (#245: ee64d04, ef845e8) rebased on framework main. Advances the pin from the current main pin (ab38b96) to that tip, keeping API workflow_path support + matching CLI in lockstep. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * style: format drizzle 0029 migration metadata (oxfmt) The drizzle-kit-generated 0029 snapshot + journal weren't oxfmt-formatted, which the full-repo `vp fmt --check` in CI rejects. Formatting only — the JSON data is byte-for-byte identical when canonicalized (verified via jq). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: re-point framework submodule to #245 merge (de1d581) #245 squash-merged to framework main as de1d581. Move the pin off the now-deleted PR-branch tip (ef845e8) onto the merge commit on main. Tree-identical to ef845e8 (verified via git diff), so no code change from what CI validated — this only makes the pin a real main commit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now you can't opt out from SSR per page when using Void.
This PR changes that, adding a per-page
export const ssr = falsesupport for pages routes.When set, it renders the client-only shells with loader data, head output, assets, and if using React, dev preamble support
Context