Repository navigation
fix(env): apply public defaults to client env - #211
Merged
Merged
Conversation
✅ Deploy Preview for staging-void-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cpojer
approved these changes
May 23, 2026
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
* docs(plan): SDD plan 0076 — void build logs CLI Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(api): extract isTerminalBuildStatus into shared build-status module Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(api): owner-guarded build list + build logs routes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(plan): reformat 0076 (oxfmt) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs: note user-facing container build logs via void build logs Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(api): surface DO-authoritative terminal status on build logs read Adversarial-review finding: the build-logs route derived terminal only from the Postgres row, which can lag ACTIVE until the stale reaper if a completion path's PG write throws (DO/container already terminal). handleReadLogs now additively returns the DO-local status/terminal; the route ORs it with the PG-derived signal so --follow stops promptly. Purely additive on the read path — no terminal-write path changed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(api): re-read Postgres so the DB status wins over a lost-CAS DO status Confirm-closure finding: when the DO reports terminal but our pre-DO PG snapshot was non-terminal, re-read the build row — a concurrent terminalizer may have committed cancelled/failed while the DO's local status (lost CAS) still reads complete. Fresh terminal PG status wins; only the genuine stale-active window (PG still non-terminal) trusts the DO status. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: bump framework submodule to merged `void build logs` CLI (#244) Re-points the framework submodule to ab38b96 on framework main — the squash-merge of #244 (the `void build logs` CLI) — now that it has landed. Aligns the owner-guarded build-logs API routes in this PR with the CLI that consumes them. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose schema defaults to the Vite client environment, so that client-exposed keys receive default values, respecting user-provided values.
Resolves void-sdk/void#45