Repository navigation
fix: Add /__void/ready handler to framework-mode wrapper - #203
Merged
Merged
Conversation
✅ Deploy Preview for staging-void-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /__void/ready, so the request fell through to the user's framework handler. For SvelteKit on Cloudflare, that path is routed toenv.ASSETS, which returns the well-known stub"Assets have not yet been deployed to this script."during the WfP asset-propagation window./__void/readyon the freshly-uploaded worker before dispatching migrations and expects a JSON{ ready: true }response. The asset stub fails every retry, so framework deploys with at least one pending migration time out the probe (~63s) and abort with"worker readiness probe failed: new worker not reachable after retries". Meanwhilevoid db migrate --remotesucceeds because it bypasses the worker entirely.router/compile.ts) into the framework-mode wrapper: respond toGET /__void/readywithResponse.json({ ready: true })before delegating to the user's originalfetch.Test plan
wrapper.test.tsasserts the wrapper emits the/__void/readybranch returning{ ready: true }, ordered before the fall-through tooriginal.fetch.wrapper.test.tstests pass.🤖 Generated with Claude Code
Note
Low Risk
Low risk: adds a small internal route in the generated wrapper plus a unit test; behavior only changes for
GET /__void/readywhen wrapper interception is enabled.Overview
Fixes framework-mode wrapper generation to intercept
GET /__void/readyand returnResponse.json({ ready: true })before delegating tooriginal.fetch, preventing readiness probes from falling through to framework asset handlers during deploy propagation.Adds a unit test asserting the
/__void/readybranch is emitted in the generated wrapper and appears before theoriginal.fetchfall-through.Reviewed by Cursor Bugbot for commit 25f4229. Bugbot is set up for automated code reviews on this repo. Configure here.