Repository navigation
Conversation
✅ Deploy Preview for staging-void-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
…rod domain) (#196) The "Void Build" check-run's details_url was hardcoded `https://${projectSlug}.void.app` at every call site, so on staging the check run linked to the production traffic domain instead of `*.staging.void.app` (observed live: a staging build's check-run pointed at `moonglade.void.app`). Add a `projectUrl(config)` helper that resolves the base domain from the per-environment `SITE_DOMAIN` binding (`env.SITE_DOMAIN ?? SITE_DOMAIN`) — the same source the deploy-URL output uses — and route all 8 check-run details_url emitters through it: the create POST, the 5 direct terminal finalizes, the `finalizeCheckRunToStatus` status→conclusion helper, and cancelBuild's finalize (which previously passed no details_url at all). Prod (SITE_DOMAIN unset or `void.app`) is byte-identical to before. Tests: staging create+finalize link to `{slug}.staging.void.app`; the finalizeCheckRunToStatus PATCH path (pre-start prior-run finalize) links to staging; unset SITE_DOMAIN falls back to prod; cancelBuild now emits details_url. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.