Skip to content

fix(runtime): use .node-version for the shared Node 24 pin - #3269

Open
fengmk2 wants to merge 14 commits into
mainfrom
fix/pin-default-node-24
Open

fengmk2 wants to merge 14 commits into
mainfrom
fix/pin-default-node-24

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

The root .node-version pins Node.js 24.22.1 for development, CI, default installation, and unconfigured projects. Each release embeds this value at build time. Explicit runtime selections remain supported.

.github/workflows/upgrade-deps.yml updates the pin to the latest stable 24.x release. Nix follows the major; flake.lock controls its exact package version.

Snapshot tests reuse prewarmed runtimes, including version ranges and the lts and latest aliases.

Node.js version consistency during vp upgrade is tracked in #2740.

flowchart LR
    subgraph Build["Release build"]
        A[".node-version"] --> B["Build and publish native vp<br/>Embed DEFAULT_NODE_VERSION"]
    end

    subgraph Install["Default installation"]
        C["install.sh<br/>VP_VERSION=latest<br/>Download target vp"] --> D["Target vp: self-setup<br/>Install with its Node pin"]
    end

    B -->|"Release artifact"| C
Loading

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-pin-default-node-24-viteplus-dev.voidzero-docs.workers.dev (commit 57987ee)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://2db64a84-viteplus-dev.voidzero-docs.workers.dev 57987ee 2026-10-29T14:36:21.818Z Visit the dashboard ↗
  • Build: In progress 🔵

View logs ↗
3c67091 2026-10-29T14:12:52.854Z View logs ↗
  • Build: In progress 🔵

View logs ↗
e09f799 2026-10-29T14:06:24.428Z View logs ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://07944244-viteplus-dev.voidzero-docs.workers.dev 5ccc08e 2026-10-29T13:49:23.890Z Visit the dashboard ↗
  • Build: In progress 🔵

View logs ↗
4eb6e6a 2026-10-29T13:27:10.758Z View logs ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://2dc4be8c-viteplus-dev.voidzero-docs.workers.dev 659ec3f 2026-10-29T12:30:54.430Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://e850f852-viteplus-dev.voidzero-docs.workers.dev f29b8b5 2026-10-29T12:23:55.630Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://d3f7f41e-viteplus-dev.voidzero-docs.workers.dev 82f9cb6 2026-10-29T12:21:43.696Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://486a8654-viteplus-dev.voidzero-docs.workers.dev bf2ee2e 2026-10-29T12:03:09.451Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://71032fe1-viteplus-dev.voidzero-docs.workers.dev 32d60db 2026-10-29T11:57:44.312Z Visit the dashboard ↗

View all previews: View all previews ↗

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

✅ Staging deployment successful!

Preview: https://viteplus-staging.void.app/
Commit: 57987ee

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

CLI artifact sizes (57987ee)

Final release artifacts built by the canonical build-upstream and build-windows-cli actions.
The dist rows use the Linux build. The core total excludes .node files to match the release artifact.

Artifact Format Base PR Change
packages/cli/dist Directory total 2.26 MiB 2.26 MiB 0 B (0.00%)
packages/core/dist Directory total 4.07 MiB 4.07 MiB 0 B (0.00%)
Combined package dist Directory total 6.34 MiB 6.34 MiB 0 B (0.00%)
vp (Linux x64) Binary 8.27 MiB 8.26 MiB -12.02 KiB (-0.14%)
vp (Linux x64) gzip -9 3.78 MiB 3.77 MiB -3.93 KiB (-0.10%)
NAPI (Linux x64) Binary 35.53 MiB 35.53 MiB 0 B (0.00%)
NAPI (Linux x64) gzip -9 14.15 MiB 14.15 MiB 0 B (0.00%)
vp (macOS ARM64) Binary 5.39 MiB 5.39 MiB -64 B (-0.00%)
vp (macOS ARM64) gzip -9 3.21 MiB 3.21 MiB -3.67 KiB (-0.11%)
NAPI (macOS ARM64) Binary 42.30 MiB 42.30 MiB 0 B (0.00%)
NAPI (macOS ARM64) gzip -9 18.28 MiB 18.28 MiB 0 B (0.00%)
vp (Windows x64) Binary 6.12 MiB 6.11 MiB -9.00 KiB (-0.14%)
vp (Windows x64) gzip -9 2.83 MiB 2.83 MiB -3.22 KiB (-0.11%)
NAPI (Windows x64) Binary 31.55 MiB 31.55 MiB 0 B (0.00%)
NAPI (Windows x64) gzip -9 12.85 MiB 12.85 MiB +8 B (+0.00%)
Trampoline (Windows x64) Binary 13.50 KiB 13.50 KiB 0 B (0.00%)
Trampoline (Windows x64) gzip -9 7.09 KiB 7.09 KiB 0 B (0.00%)
Installer (Windows x64) Binary 4.68 MiB 4.65 MiB -31.50 KiB (-0.66%)
Installer (Windows x64) gzip -9 2.24 MiB 2.23 MiB -15.06 KiB (-0.66%)

@fengmk2 fengmk2 changed the title fix(runtime): pin default Node.js to 24 and automate updates fix(runtime): use .node-version for the shared Node 24 pin Oct 29, 2026
@fengmk2
fengmk2 force-pushed the fix/pin-default-node-24 branch from 1f99415 to 08cd4b1 Compare October 29, 2026 06:27
@fengmk2
fengmk2 changed the base branch from main to ci/arm64-libatomic October 29, 2026 06:28
@fengmk2
fengmk2 added this pull request to stack #3270 October 29, 2026 06:31
@fengmk2
fengmk2 force-pushed the fix/pin-default-node-24 branch from 08cd4b1 to ed0ab24 Compare October 29, 2026 06:59
Base automatically changed from ci/arm64-libatomic to main October 29, 2026 07:28
@fengmk2
fengmk2 force-pushed the fix/pin-default-node-24 branch from ed0ab24 to 4a00d4a Compare October 29, 2026 07:28
@fengmk2
fengmk2 marked this pull request as draft October 29, 2026 08:08
@fengmk2
fengmk2 marked this pull request as ready for review October 29, 2026 08:51
@fengmk2 fengmk2 self-assigned this Oct 29, 2026
@fengmk2
fengmk2 force-pushed the fix/pin-default-node-24 branch from bf2ee2e to 82f9cb6 Compare October 29, 2026 12:19
@fengmk2 fengmk2 added the preview-build Publish this PR's commits to the registry bridge as preview builds label Oct 29, 2026 — with ChatGPT Codex Connector
@fengmk2
fengmk2 force-pushed the fix/pin-default-node-24 branch from 3c67091 to 57987ee Compare October 29, 2026 14:34
@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw preview-build Publish this PR's commits to the registry bridge as preview builds and removed preview-build Publish this PR's commits to the registry bridge as preview builds labels Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Preview binary sizes (57987ee)

Compared with the latest stable release, v1.4.0. Preview build.
Each row measures one binary. Negative changes mean a smaller preview binary.

Binary Latest release Preview Change
vp (macOS ARM64) 5.38 MiB 5.39 MiB +16.34 KiB (+0.30%)
NAPI (macOS ARM64) 42.20 MiB 42.27 MiB +64.55 KiB (+0.15%)
vp (macOS x64) 6.82 MiB 6.84 MiB +28.10 KiB (+0.40%)
NAPI (macOS x64) 47.34 MiB 47.42 MiB +84.12 KiB (+0.17%)
vp (Linux ARM64 GNU) 6.81 MiB 6.84 MiB +24.02 KiB (+0.34%)
NAPI (Linux ARM64 GNU) 31.44 MiB 31.52 MiB +83.25 KiB (+0.26%)
vp (Linux ARM64 musl) 6.88 MiB 6.91 MiB +28.91 KiB (+0.41%)
NAPI (Linux ARM64 musl) 30.67 MiB 30.71 MiB +43.44 KiB (+0.14%)
vp (Linux x64 GNU) 8.22 MiB 8.26 MiB +32.02 KiB (+0.38%)
NAPI (Linux x64 GNU) 35.45 MiB 35.53 MiB +79.31 KiB (+0.22%)
vp (Linux x64 musl) 8.29 MiB 8.33 MiB +38.39 KiB (+0.45%)
NAPI (Linux x64 musl) 34.43 MiB 34.49 MiB +52.38 KiB (+0.15%)
vp (Windows x64) 6.09 MiB 6.12 MiB +31.50 KiB (+0.50%)
NAPI (Windows x64) 31.16 MiB 31.21 MiB +50.00 KiB (+0.16%)
Trampoline (Windows x64) 13.00 KiB 13.00 KiB 0 B (0.00%)
Installer (Windows x64) 4.67 MiB 4.66 MiB -17.50 KiB (-0.37%)
vp (Windows ARM64) 5.33 MiB 5.35 MiB +21.50 KiB (+0.39%)
NAPI (Windows ARM64) 27.57 MiB 27.60 MiB +38.50 KiB (+0.14%)
Trampoline (Windows ARM64) 13.00 KiB 13.00 KiB 0 B (0.00%)
Installer (Windows ARM64) 3.85 MiB 3.83 MiB -17.00 KiB (-0.43%)
gzip -9 sizes
Binary Latest release Preview Change
vp (macOS ARM64) 3.20 MiB 3.21 MiB +12.56 KiB (+0.38%)
NAPI (macOS ARM64) 18.25 MiB 18.28 MiB +28.18 KiB (+0.15%)
vp (macOS x64) 3.38 MiB 3.39 MiB +14.51 KiB (+0.42%)
NAPI (macOS x64) 19.44 MiB 19.48 MiB +36.98 KiB (+0.19%)
vp (Linux ARM64 GNU) 3.69 MiB 3.70 MiB +13.18 KiB (+0.35%)
NAPI (Linux ARM64 GNU) 13.31 MiB 13.34 MiB +26.89 KiB (+0.20%)
vp (Linux ARM64 musl) 3.71 MiB 3.73 MiB +15.42 KiB (+0.41%)
NAPI (Linux ARM64 musl) 13.01 MiB 13.03 MiB +19.05 KiB (+0.14%)
vp (Linux x64 GNU) 3.76 MiB 3.77 MiB +15.57 KiB (+0.40%)
NAPI (Linux x64 GNU) 14.12 MiB 14.15 MiB +30.13 KiB (+0.21%)
vp (Linux x64 musl) 3.78 MiB 3.80 MiB +15.16 KiB (+0.39%)
NAPI (Linux x64 musl) 13.66 MiB 13.68 MiB +18.47 KiB (+0.13%)
vp (Windows x64) 2.82 MiB 2.83 MiB +11.30 KiB (+0.39%)
NAPI (Windows x64) 12.69 MiB 12.71 MiB +20.00 KiB (+0.15%)
Trampoline (Windows x64) 7.14 KiB 7.14 KiB -2 B (-0.03%)
Installer (Windows x64) 2.24 MiB 2.23 MiB -10.00 KiB (-0.44%)
vp (Windows ARM64) 2.69 MiB 2.70 MiB +7.16 KiB (+0.26%)
NAPI (Windows ARM64) 12.05 MiB 12.06 MiB +16.64 KiB (+0.13%)
Trampoline (Windows ARM64) 6.93 KiB 6.93 KiB 0 B (0.00%)
Installer (Windows ARM64) 2.14 MiB 2.12 MiB -10.74 KiB (-0.49%)

Raw sizes are uncompressed file sizes. gzip sizes recompress each binary at level 9; they are not package or download archive sizes.
The baseline uses published release files, including NAPI packages from npm at the same version. Build versions and toolchains can affect the difference.

@github-actions

Copy link
Copy Markdown
Contributor

Registry bridge build (57987ee)

This commit build is published to the registry bridge, which serves these as ordinary npm versions (every other package proxies to npmjs):

Package Version
vite-plus 0.0.0-commit.57987eeda8f89cb59458dba37191f7399eb72240
@voidzero-dev/vite-plus-core 0.0.0-commit.57987eeda8f89cb59458dba37191f7399eb72240
create-vite-plus 0.0.0-commit.57987eeda8f89cb59458dba37191f7399eb72240

Install the Vite+ CLI built from this commit, then migrate a project:

# macOS / Linux
curl -fsSL https://raw.githubusercontent.com/voidzero-dev/vite-plus/57987eeda8f89cb59458dba37191f7399eb72240/packages/cli/install.sh | VP_PR_VERSION=3269 VP_LEGACY_INSTALLER_URL=https://raw.githubusercontent.com/voidzero-dev/vite-plus/57987eeda8f89cb59458dba37191f7399eb72240/packages/cli/install-legacy.sh bash
# Windows (PowerShell)
$env:VP_PR_VERSION="3269"; $env:VP_LEGACY_INSTALLER_URL="https://raw.githubusercontent.com/voidzero-dev/vite-plus/57987eeda8f89cb59458dba37191f7399eb72240/packages/cli/install-legacy.ps1"; irm https://raw.githubusercontent.com/voidzero-dev/vite-plus/57987eeda8f89cb59458dba37191f7399eb72240/packages/cli/install.ps1 | iex

Or download the standalone Windows installer built from this commit:

Architecture Installer
x64 vp-setup-x86_64-pc-windows-msvc.exe
Arm64 vp-setup-aarch64-pc-windows-msvc.exe

GitHub requires you to sign in and downloads each installer as a ZIP artifact. Extract vp-setup.exe, then run it against this preview build:

.\vp-setup.exe --version "0.0.0-commit.57987eeda8f89cb59458dba37191f7399eb72240" --registry "https://registry-bridge.viteplus.dev/"

After installing, upgrade the current project's vite-plus to this test build with:

vp migrate

Or create a new project from this commit without installing the CLI:

export npm_config_registry=https://registry-bridge.viteplus.dev/ pnpm_config_registry=https://registry-bridge.viteplus.dev/
pnpm create vite-plus@0.0.0-commit.57987eeda8f89cb59458dba37191f7399eb72240 # or: npm create vite-plus@0.0.0-commit.57987eeda8f89cb59458dba37191f7399eb72240
$env:npm_config_registry="https://registry-bridge.viteplus.dev/"; $env:pnpm_config_registry="https://registry-bridge.viteplus.dev/"
pnpm create vite-plus@0.0.0-commit.57987eeda8f89cb59458dba37191f7399eb72240 # or: npm create vite-plus@0.0.0-commit.57987eeda8f89cb59458dba37191f7399eb72240

pnpm 11+ reads pnpm_config_registry, npm and older pnpm read npm_config_registry. The new project pins this build, so keep the registry set for later installs, or configure it as below.

Or point your package manager at the bridge registry https://registry-bridge.viteplus.dev/:

Package manager Registry config
npm / pnpm / Bun .npmrc: registry=https://registry-bridge.viteplus.dev/
Yarn (v2+) .yarnrc.yml: npmRegistryServer: "https://registry-bridge.viteplus.dev/"

Then pin the build (vite aliases to vite-plus-core; pnpm can use a catalog, npm an overrides entry):

{
  "devDependencies": {
    "vite-plus": "0.0.0-commit.57987eeda8f89cb59458dba37191f7399eb72240",
    "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.57987eeda8f89cb59458dba37191f7399eb72240"
  }
}

@github-actions

Copy link
Copy Markdown
Contributor

🐳 Docker preview image

Built from this PR's registry bridge build:

Image Compressed size
ghcr.io/voidzero-dev/vite-plus:pr-3269 218MB
# remove any stale local copy from a previous run, then pull fresh
docker rmi ghcr.io/voidzero-dev/vite-plus:pr-3269 2>/dev/null; docker pull ghcr.io/voidzero-dev/vite-plus:pr-3269

Quick check:

docker run --rm ghcr.io/voidzero-dev/vite-plus:pr-3269 vp --version

See docs/guide/docker.md for usage.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview-build Publish this PR's commits to the registry bridge as preview builds test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: sfw

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants