Repository navigation
test(pm): run package manager tests offline and drop vt_workspace duplicates - #3171
Merged
Merged
Conversation
These tests exercised vt_workspace::find_package_root and find_workspace_root, which come from the vite-task git dependency. Keep the two contracts this crate relies on: pnpm-workspace.yaml wins over package.json workspaces for detection, and an invalid package.json is an error rather than no selection.
About 20 tests fetched pnpm, yarn, and dist-tags from registry.npmjs.org through a VP_HOME shared across runs, so they needed the network and could fail on a stale cache. Detection tests now check the detected manager directly, or build against a mock registry with pre-seeded installs. Download, hash, shim, and pnpm 12 native tests serve fixture tarballs whose digests the tests compute.
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
liangmiQwQ
marked this pull request as ready for review
October 21, 2026 13:24
fengmk2
approved these changes
Oct 21, 2026
Member
|
Need to fix conflicts first. |
Collaborator
Author
|
fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About 20 package-manager tests in
vp_pm_clidownloaded pnpm, yarn and dist-tags from registry.npmjs.org into aVP_HOMEshared across runs. They needed the network, and a stale shared cache could make them fail.This PR moves them offline:
pnpm.cmdon Windows instead of being skipped there.It also removes 18 tests that only exercised
vt_workspaceroot finding, which comes from the vite-task dependency. It keeps the two contracts this crate relies on:pnpm-workspace.yamlwins overpackage.jsonworkspaces for detection, and an invalidpackage.jsonis an error.The crate's test run drops from about 44–61s to about 24s, with no network access.
🤖 Generated with Claude Code