Repository navigation
test: un-ignore hash tests and remove duplicate Rust unit tests - #3145
Draft
liangmiQwQ wants to merge 7 commits into
Draft
liangmiQwQ wants to merge 7 commits into
liangmiQwQ wants to merge 7 commits into
Conversation
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_verify_file_hash_sha1andtest_verify_file_hash_sha224were ignored as flaky because they hashed the file before the tokio write finished. This PR adds the sameflush()that the SRI test already uses, re-enables them, and assertsHashMismatchfor a wrong hash.test_http_client_retry_on_server_erroronly asserted an error, so it also passed without retries. It now asserts 3 requests (1 request and 2 retries).This PR also removes tests that repeat another test's code path and assertions:
vp_static_config:resolves_ts_configandresolves_js_configvp_migration: five single-line reference-types cases already intest_rewrite_reference_types_env_d_ts_style, andtest_rewrite_import_content_vitevp_setup: two tests that rebuilt the package name inline instead of calling production code. Theresolve_platform_packagemock tests cover the real name.No behavior changes.
🤖 Generated with Claude Code