Repository navigation
test(js-runtime): resolve Node aliases against a fixed version index - #3144
Merged
Merged
Conversation
The provider tests fetched the live nodejs.org index and pinned release-dependent values such as `lts/-1 == 22`, which breaks when Node.js 26 enters LTS. Serve a fixed index from a local mirror instead and assert exact versions.
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
liangmiQwQ
marked this pull request as ready for review
October 20, 2026 14:21
fengmk2
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node provider tests fetch the live nodejs.org index and pin release-dependent values. For example,
test_resolve_lts_alias_offsetexpectslts/-1to resolve to Node 22, so it fails on every CI job once Node 26 enters LTS.This PR serves a fixed
index.jsonfrom a local mirror with an isolatedVP_HOME. The alias, codename, offset, and cached-version tests now assert exact versions instead of release-dependent ranges. The helper also expects one index request per test, which covers the index cache.No behavior changes.
🤖 Generated with Claude Code