Repository navigation
Conversation
Contributor
|
✅ Staging deployment successful! Preview: https://viteplus-staging.void.app/ |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-upstream-vite-overrides-viteplus-dev.voidzero-docs.workers.dev (commit 45c3c5e)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
CLI artifact sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
packages/cli/dist |
Directory total | 2.17 MiB | 22.62 MiB | +20.45 MiB (+943.83%) |
packages/core/dist |
Directory total | 4.08 MiB | 4.08 MiB | 0 B (0.00%) |
| Combined package dist | Directory total | 6.25 MiB | 26.70 MiB | +20.45 MiB (+327.18%) |
vp (Linux x64) |
Binary | 7.27 MiB | 7.27 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 3.37 MiB | 3.37 MiB | +525 B (+0.01%) |
| NAPI (Linux x64) | Binary | 35.14 MiB | 35.14 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 14.01 MiB | 14.01 MiB | +646 B (+0.00%) |
vp (macOS ARM64) |
Binary | 4.82 MiB | 4.82 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 2.88 MiB | 2.88 MiB | +406 B (+0.01%) |
| NAPI (macOS ARM64) | Binary | 42.01 MiB | 42.01 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 18.17 MiB | 18.17 MiB | +866 B (+0.00%) |
vp (Windows x64) |
Binary | 5.31 MiB | 5.31 MiB | +1.50 KiB (+0.03%) |
vp (Windows x64) |
gzip -9 | 2.48 MiB | 2.48 MiB | +96 B (+0.00%) |
| NAPI (Windows x64) | Binary | 31.20 MiB | 31.20 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 12.72 MiB | 12.72 MiB | +335 B (+0.00%) |
| Trampoline (Windows x64) | Binary | 13.50 KiB | 13.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 7.09 KiB | 7.09 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 3.66 MiB | 3.66 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 1.79 MiB | 1.79 MiB | -2 B (-0.00%) |
fengmk2
added
test: e2e
fengmk2
force-pushed
the
fix/upstream-vite-overrides
branch
from
October 20, 2026 17:06
32e822d to
45c3c5e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
viteoverride breaksvp packbecause upstream Vite has novite/packexport. Pack now ships insidevite-plus, with its runtime and type declarations. The bundle includes tsdown and Rolldown. Release builds use the existing native platform packages.Public Vite APIs, configuration loading, and Vite commands retain the existing
vitealias. This change adds no direct@voidzero-dev/vite-plus-coredependency.Set
VP_USE_PROJECT_VITE=1to permit upstream Vite forvp dev,vp build, andvp preview. The CLI and the project's declaredvitedependency must resolve to the same package path. Partial overrides and separate copies of the same version fail this check. Commands always use the CLI's dependency, including its publicbinentry for published and localfile:packages. Without the setting, these commands retain the core name and version checks.Apply the override to all
vitedependencies so Vitest uses the same Vite package.vp testandvite-plus/testretain the same Vitest instance.The diagram shows an ecosystem CI override to upstream Vite.
flowchart TB subgraph before["Before: upstream Vite override"] direction LR B_PACK["vp pack"] -->|"Missing vite/pack export"| B_VITE["vite<br/>Upstream Vite"] B_CLI["vp dev / build / preview"] -->|"Core check fails"| B_VITE B_API["Public Vite APIs + config + Vitest"] --> B_VITE end subgraph after["After: upstream Vite override"] direction LR A_PACK["vp pack"] --> A_BUNDLE["Pack + Rolldown<br/>Inside vite-plus"] A_PACK -->|"Configuration loading"| A_VITE["One upstream Vite package"] A_CLI["vp dev / build / preview"] -->|"VP_USE_PROJECT_VITE=1<br/>CLI vite dependency"| A_VITE A_PROJECT["Project vite dependency"] -->|"Must resolve to the same path"| A_VITE A_API["Public Vite APIs + Vitest"] --> A_VITE end before ~~~ after classDef blocked fill:#ffebe9,stroke:#cf222e,color:#82071e classDef bundled fill:#dafbe1,stroke:#1a7f37,color:#116329 class B_PACK,B_CLI blocked class A_BUNDLE,A_VITE bundledCloses #3135.