Repository navigation
fix(pm): verify Bun request pins on fresh installs - #3134
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Verify a supplied pin against the main bun tarball before downloading the platform package. Preserve platform integrity verification and leave cached install pin checks for a separate change. Cover matching and mismatched pins, unpinned installs, and platform hash mismatches with isolated mock registry tests.
675a88c to
9a4a399
Compare
|
@codex reivew |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
I've made a fix for the test failure and am verifying it. |
Keep the mock server alive for all cases so other tests cannot reuse its pooled HTTP connections while the Bun test runtime waits for the environment lock. Reset mocks and request history between cases.
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
Fresh Bun installs previously ignored the integrity hash in
packageManager. They now reject mismatched pins by verifying the mainbuntarball, matching the existing pnpm 12+ behavior.