Skip to content

fix(migrate): keep existing .nvmrc pins - #3126

Open
liangmiQwQ wants to merge 3 commits into
voidzero-dev:mainfrom
liangmiQwQ:feat/migrate-keep-nvmrc
Open

liangmiQwQ wants to merge 3 commits into
voidzero-dev:mainfrom
liangmiQwQ:feat/migrate-keep-nvmrc

Conversation

@liangmiQwQ

Copy link
Copy Markdown
Collaborator

vp migrate currently converts .nvmrc to .node-version and deletes .nvmrc. This was added in #1159, before Vite+ could read .nvmrc. Since #2244, Vite+ reads .nvmrc directly, and #2676 keeps .nvmrc pins in vp env pin.

The conversion now causes problems:

  • Deleting .nvmrc breaks nvm, fnm, and other tools that still read it. Only actions/setup-node references were rewritten.
  • It can change the resolved Node.js version. .nvmrc ranks below engines.node and devEngines.runtime, while .node-version ranks above them.
  • The parser only read the first line, so .nvmrc files with comments were rejected.

This PR keeps .nvmrc as-is. Migration now only converts Volta's volta.node, and skips it when .nvmrc exists, because a new .node-version would take priority over that .nvmrc.

This PR also removes parseNvmrcVersion and the GitHub Actions node-version-file rewrite, which only existed for the removed file.

🤖 Generated with Claude Code

@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T15:14:34.151556Z 98be74f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98be74fe6c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/setup.ts
@liangmiQwQ
liangmiQwQ marked this pull request as ready for review October 19, 2026 21:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant