Repository navigation
refactor(env): share .nvmrc line parsing between reading and pinning - #3125
Open
liangmiQwQ wants to merge 3 commits into
Open
liangmiQwQ wants to merge 3 commits into
liangmiQwQ wants to merge 3 commits into
Conversation
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
liangmiQwQ
marked this pull request as ready for review
October 19, 2026 21:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.nvmrcline rules (strip#comments, skip blank andkey=valuelines, reject multiple declarations) were written twice: once inread_nvmrc_fileand once innvmrc_version_spanforvp env pin, with a comment asking them to stay in sync.This PR moves those rules into a single
nvmrc_version_spansiterator invp_js_runtimethat yields the byte range of each version declaration. Reading builds on it through a new pureparse_nvmrc_content, and pinning uses the same ranges to replace the version in place. The content cases intest_read_nvmrc_filenow run against the pure parser without temp files.No behavior changes.
🤖 Generated with Claude Code