Skip to content

fix(migrate): keep vite/rolldown imports as they are - #3070

Merged
fengmk2 merged 2 commits into
voidzero-dev:mainfrom
Crimson341:fix/migrate-keep-vite-rolldown-imports
Oct 20, 2026
Merged

fengmk2 merged 2 commits into
voidzero-dev:mainfrom
Crimson341:fix/migrate-keep-vite-rolldown-imports

Conversation

@Crimson341

Copy link
Copy Markdown
Contributor

vp migrate rewrote vite/rolldown/plugins to vite-plus/rolldown/plugins, which vite-plus doesn't export. Leave vite/rolldown and vite/rolldown/* untouched in imports, exports, require, dynamic import, declare module and triple-slash references.

Fixes #3050

@fengmk2

fengmk2 commented Oct 20, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T07:15:25.699950Z 40206ba Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 40206ba4ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2 fengmk2 self-assigned this Oct 20, 2026

@fengmk2 fengmk2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crimson341 Thanks!

@fengmk2
fengmk2 merged commit 9cef17e into voidzero-dev:main Oct 20, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the vp migrate command wrongly rewrite "vite/rolldown/plugins" to "vite-plus/rolldown/plugins"

2 participants