Support upstream Vite overrides in ecosystem CI #3135

Activity

1. fengmk2

   added

   pending triage

   on Oct 20, 2026
2. fengmk2

   self-assigned this

   on Oct 20, 2026
3. fengmk2

   added the

   Task

   issue type on Oct 20, 2026
4. fengmk2

   added

   enhancementNew feature or requestNew feature or request

   on Oct 20, 2026
5. fengmk2 commented on Oct 20, 2026

   

   fengmk2

   on Oct 20, 2026

   Last edited by fengmk2

   MemberAuthor

   More actions

   Related workaround PR: vitejs/vite-ecosystem-ci#536.

   The draft lets the vinext suite run against upstream Vite while preserving the Vite+ core for pack.
6. fengmk2 commented on Oct 21, 2026

   

   fengmk2

   on Oct 21, 2026

   MemberAuthor

   More actions

   A revised proposal for discussion: extract a shared runtime package for pack and Rolldown. The package name below is provisional, and this design is not yet agreed.

   The current approach in draft #3142 copies pack and Rolldown into vite-plus while core still contains them. This duplicates the bundled tools in normal installations. Adding a direct canonical core dependency also risks restoring the alias/canonical package duplication addressed by the Vite module identity work.

   The proposed ownership would be:

   • @voidzero-dev/vite-plus-runtime owns tsdown, its CSS/executable extensions, Rolldown, pluginutils, declarations, and worker files.
   • @voidzero-dev/vite-plus-core retains Vite and depends on the shared runtime. Its existing ./pack and ./rolldown* exports become small JavaScript and type forwarders.
   • vite-plus retains its existing vite alias and adds an exact dependency on the same runtime release. Pack imports the runtime directly. The CLI has no direct canonical core dependency.

   The implementations move into the new package; they are removed from core and the CLI.

   flowchart TD
       project["Project and Vite plugins"] -->|"vite alias"| core["vite-plus-core: Vite"]
       cli["vite-plus"] -->|"vite alias"| core
       cli -->|"pack"| runtime["Shared runtime: tsdown + Rolldown + pluginutils"]
       core -->|"Rolldown and compatibility exports"| runtime
       cli --> native["Existing native platform packages"]
       runtime --> native
   

   Loading

   With VP_USE_PROJECT_VITE=1, the project and CLI replace their vite dependency with the same upstream package. Vite commands, public APIs, configuration loading, and Vitest must still use that same Vite instance. Pack keeps its matching runtime release. The opt-in relaxes Vite's release check, while the Vite identity check and pack runtime version check remain.

   The runtime uses the existing native platform packages through declared dependencies, with no dependency back to the CLI. Release and preview publishing would gain a tier: platform packages → runtime → core → CLI. Version stamping, local registry packing, toolchain metadata, and license generation would also need updates.

   An alternative is to keep tsdown in the CLI and let pack reuse Vite's Rolldown: vite/rolldown* for core, or rolldown* resolved from upstream Vite's dependency scope. Upstream Vite 8.3.4 does not export vite/rolldown, so that approach needs a resolver. It avoids a new package, but couples pack to the Rolldown version under test. Pack also uses experimental Rolldown APIs, so an upstream change could break postinstall packaging before the Vite tests run.

   Approach	Rolldown implementations bundled in Vite+ packages	Pack follows upstream Rolldown	New package
   Copy pack and Rolldown into the CLI	Two	No	No
   Reuse the selected Vite's Rolldown	One	Yes	No
   Extract a shared runtime	One	No	One

   The shared runtime guarantees one owner for our bundled Rolldown. It does not guarantee one installed Rolldown during upstream CI: upstream Vite can bring its own version alongside pack's fixed version. Package-manager peer contexts also still need validation.

   An isolated prototype installed from tarballs with pnpm shared the same runtime path between core and the CLI. Pack JavaScript, declaration, and CSS builds, Vite builds, and environment guard checks passed with core and upstream Vite. This used minimal CLI forwarders, not a complete rebuilt CLI. Full CLI/Vitest, release bindings, other package managers, and worker coverage remain outstanding; worker probes also exposed baseline failures that need investigation.

   Before changing the implementation, we should agree on:

   1. Should pack retain a fixed Rolldown when Vite is overridden, or should pack participate in testing upstream Rolldown too?
   2. Is one new shared runtime package and its release integration an acceptable cost?
   3. Is the requirement one Vite+-bundled Rolldown implementation, or one installed Rolldown across the entire overridden project?

   My current preference is the shared runtime boundary, subject to that discussion.
7. fengmk2

   set

   Priority

   to

   Low

   on Oct 21, 2026