Repository navigation
fix(import-elision): count an aliased Angular param decorator as removed - #621
Merged
Merged
Conversation
`@I(TOKEN)` for `import { Inject as I }` is removed like `@Inject(TOKEN)`,
but the removed-reference set matched the local name, so a file with both
kept an unused TOKEN import.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #606.
Problem
With
advancedOptimizations, #606 removes an@Inject(TOKEN)import only when every value use ofTOKENsits inside a decorator that compilation removes. To decide that, it matched the decorator's local name, so@I(TOKEN)forimport { Inject as I }didn't count. The compiler does remove it, and the factory usesi1.TOKEN. A file with both shapes therefore kept an import that nothing uses:Main removed it; #606 kept it.
Fix
Decide by what the decorator resolves to (
angular_param_decorator, which follows aliases andng.Inject), not by its local name.Checks
test_aliased_inject_counts_as_removed.cargo test --workspace: 3415 passed.i1from./tokensand no namedTOKEN, like main.🤖 Generated with Claude Code