Repository navigation
fix(metadata): keep an optional-call signal query predicate as written - #612
Merged
Merged
Conversation
`viewChild(a?.b())` stays as written in setClassMetadata, like a plain call: `ts.isCallExpression` is true for an optional call, so ngtsc does not wrap it in `forwardRef`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #602. That PR wraps a signal query predicate in
forwardRefinsetClassMetadataunless the predicate is a string or a call, like ngtsc'smemberMetadataFromSignalQuery. But an optional call was still wrapped:viewChild(tokens?.get())tokens?.get()i0.forwardRef(() => tokens?.get())tokens?.get()viewChild(tokens.get?.())tokens.get?.()i0.forwardRef(() => tokens.get?.())tokens.get?.()TypeScript models
a?.b()as aCallExpression, sots.isCallExpressionis true and ngtsc leaves it as written. oxc parses it as aChainExpression, which the check missed. At runtime both forms resolve to the same value, so this changes only how the output reads.A parenthesized or
as-castforwardRef(...)is not unwrapped; ngtsc wraps it again too (see the #602 thread).Tests
tests/signal_query_metadata_forward_ref_test.rs: a new test for a plain call,a?.b()anda.b?.(). It fails without the change.cargo test -p oxc_angular_compiler --all-features: 3499 passed.pnpm compare --fixtures: 1162 fixtures, 0 mismatches.pnpm test: 376 passed.🤖 Generated with Claude Code