Repository navigation
fix(metadata): fold number consts in a template literal's interpolations - #603
Merged
Brooooooklyn merged 1 commit intoOct 22, 2026
Merged
Conversation
`template: \`<canvas style="width: ${WIDTH}px"></canvas>\`` with
`const WIDTH = 150` left the component uncompiled: only string consts were
folded (voidzero-dev#286). Like ngtsc's partial evaluator, a `${...}` interpolation can now
also be a number literal or a same-file number const (`-2` included), converted
as JavaScript converts numbers to strings.
Member
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e7b8cf287
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Brooooooklyn
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number in an inline template's interpolation left the component uncompiled:
#286 made string consts work; number consts and literals still weren't folded. Like ngtsc's partial evaluator, a
${...}interpolation can now also be a number literal or a same-file number const (negative ones included), converted as JavaScript converts a number to a string (oxc_syntax'sToJsString). Chained consts work too (const SIZE = `${WIDTH}px`).The number consts are only used for template-literal interpolation: the string-const map used for host bindings, selectors and the rest is unchanged.
tests/template_literal_number_const_test.rscompares theconstsof two components with @angular/compiler-cli 21.0.1's:[[1, "box", 2, "width", "150px", "height", "80px"]]and[[2, "width", "150px", "margin", "-2px", "opacity", "0.5"]]. Both fail without the change.