Repository navigation
fix(lexer): a < doesn't end a @let value - #600
Merged
Merged
Conversation
`@let small = count < 10;` was cut at the `<`, which the lexer took for a tag, and reported as an incomplete @let declaration, so the component wasn't compiled. Like Angular's `_consumeLetDeclarationValue`, only a `;` outside quotes (or EOF) ends the value now.
Member
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Brooooooklyn
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@let small = count < 10;was cut at the<, which the HTML lexer took for the start of a tag, and reported as an incomplete@letdeclaration, so the component was left uncompiled.Angular's
_consumeLetDeclarationValueends the value only at a;outside quotes (or EOF), so a<is part of the expression. The lexer now does the same; the quote handling it already had is unchanged.Tests: two lexer cases next to the existing
@letones (html_lexer_test.rs), andtests/let_value_less_than_test.rs, which compilesto
const small_r1 = (ctx.count < 10);andconst both_r2 = ((ctx.a < ctx.b) && (ctx.b < ctx.c));, as @angular/compiler-cli 21.0.1 does (without the parentheses). The lexer tests fail without the change.