Repository navigation
fix(compiler): prepend synthesized signal-API decorators before explicit member decorators - #542
Merged
Merged
Conversation
…cit member decorators Upstream's getInitializerApiJitTransform inserts the synthesized decorator ahead of the member's existing decorators (`[newDecorator, ...member.node.modifiers]`), so `@Output() x = input(0)` lists the synthesized `i0.Input` before the explicit `Output` in `propDecorators`. OXC appended them instead. Insert `synthesize_signal_api_decorators` results at the front of the member's Angular decorator list, matching the upstream order. Ordering of the member's `propDecorators` array only; the set of emitted decorators is unchanged. Fixes #540
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #540.
Problem
When a member carries an explicit Angular decorator and a signal-API initializer — e.g.
@Output() x = input(0)— OXC appended the synthesized signal decorator after the explicit ones inpropDecorators. UpstreamgetInitializerApiJitTransformprepends it ([newDecorator, ...member.node.modifiers]ininitializer_api_transforms/input_function.ts:93), so the synthesized decorator comes first.Change
extract_all_jit_member_decoratorsnow splices the synthesized decorators to the front of the member's Angular decorator list instead of extending the tail.Example
Before:
x: [{type: Output}, {type: i0.Input, args: [...]}]After (matches ngtsc):
x: [{type: i0.Input, args: [...]}, {type: Output}]Testing
synthesized_decorator_precedes_explicit_member_decoratorscoversinput()+@Output()andmodel()+@HostBinding()(model synthesizes two decorators; both must precede the explicit one).cargo test -p oxc_angular_compiler: 2941 passed, 0 failed.transformAngularFileSync(..., {jit: true})).Ordering-only change; the set of emitted decorators is unchanged.