Skip to content

nethack: Add curses interface - #62341

Open
pixelflaps wants to merge 1 commit into
void-linux:masterfrom
pixelflaps:nethack-curses
Open

nethack: Add curses interface#62341
pixelflaps wants to merge 1 commit into
void-linux:masterfrom
pixelflaps:nethack-curses

Conversation

@pixelflaps

Copy link
Copy Markdown
Contributor

This change builds Nethack with support for the (optional) curses interface, allowing you to use OPTIONS=windowtype:curses in your .nethackrc. This offers better support for larger terminal windows than the default tty interface.

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64)
  • nethack cannot be cross compiled

Comment thread srcpkgs/nethack/template Outdated
hostmakedepends="flex groff"
makedepends="lua54-devel ncurses-devel ncurses-libtinfo-devel pkg-config"
depends="gzip"
depends="gzip ncurses"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right, ncurses-devel would be required in makedepends to be able to build with it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ncurses-devel was already in makedepends, which is why this PR doesn't add it. I'm away from my computer for a few days, but I can take another look when I return

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it already links against libcurses and therefor already automatically depends on ncurses-libs, so this shouldn't added.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, you are correct; I've removed the extraneous dependency and can confirm that the curses interface still works without it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants