fix: align aube install scripts and cold-cache cleanup - #176
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lukekarrys
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package-manager benchmarks aim to exclude lifecycle scripts, but aube was invoked without
--ignore-scripts. aube 2.4.0 runs builds for its bundled trusted dependencies, so Babylon's install was compiling native modules and running Puppeteer downloads while Bun and pnpm had scripts disabled.Pass
--ignore-scriptsto aube's regular install, CI command, and CI lockfile preparation. This also covers the bare command used for process counting:Also clear the configured content store returned by
aube store pathand honorXDG_CACHE_HOME. The old cleanup only removed~/.cache/aubeand~/.aube-store, leaving the current XDG data store populated across supposedly cold runs. Keep the legacy-directory cleanup for older releases. This correction can increase cold-run times; both changes are needed for comparable workloads.Validation on Linux x86-64 with aube 2.4.0 and the Babylon fixture at aff8423:
aube install --silentaube install --ignore-scripts --silentEach untraced run started without
node_modulesor a lockfile and with a fresh aube metadata cache and content store. The six runs interleaved the two commands and used the public registry; previously downloaded Puppeteer browsers remained cached. All six succeeded with the same 1,694-package graph. Separatestraceruns showed 448 execution attempts with the default policy versus 2 with scripts disabled. These measurements validate the mismatch; they do not predict the site's ARM64 results or the combined effect of correcting its store cleanup.All eight Node tests pass, including new coverage for a configured store path containing spaces, a failed store-path lookup, and preserving the store during metadata-only cleanup. Bash syntax checks and ShellCheck's error-level checks pass for the changed scripts.
AI-assisted — Tool: Codex; model: OpenAI/unavailable; version: unavailable.