Skip to content

fix: pin Yarn canary to available ARM64 release - #175

Merged
lukekarrys merged 1 commit into
mainfrom
fix/yarn-arm64-canary
Sep 22, 2026
Merged

lukekarrys merged 1 commit into
mainfrom
fix/yarn-arm64-canary

Conversation

@lukekarrys

@lukekarrys lukekarrys commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

The Yarn canary channel advertises 6.0.0-rc.21, but its Linux ARM64 npm binary returns HTTP 404. This aborts the run benchmark during Hyperfine preparation and prevents result processing.

Pin the benchmark job to the available 6.0.0-rc.20 release and make setup's version reporting honor BENCH_ZPM_VERSION. Upload benchmark results and version information after failures so redirected diagnostic logs remain available.

Validation:

  • Confirmed the rc.21 ARM64 tarball returns 404 and rc.20 returns 200.
  • Checked shell syntax, workflow YAML, and diff formatting.
  • Verified setup reporting and benchmark preparation use the pin without querying the canary channel; verified reporting's fallback when no override is set.
  • The full ARM64 benchmark suite was not run locally.

Failing job: https://github.com/vltpkg/benchmarks/actions/runs/35588817974/job/106423763722

Summary by CodeRabbit

  • Chores
    • Updated benchmark tooling to use a fixed compatible package version and avoid publishing artifacts from cancelled runs.
    • Improved setup behavior by allowing an environment-provided package version to take precedence.
    • Streamlined version retrieval to fail clearly on download errors and suppress unnecessary command output.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f91255f0-fd93-4ab2-bcf3-bdcc49baed29

📥 Commits

Reviewing files that changed from the base of the PR and between 2a654d4 and 76cedbc.

📒 Files selected for processing (2)
  • .github/workflows/benchmark.yaml
  • scripts/setup.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The setup script now supports a benchmark version override and stricter canary version fetching. The benchmark workflow pins the benchmark version and skips result and version artifact uploads after cancellation.

Changes

Benchmark version and artifact handling

Layer / File(s) Summary
Benchmark version resolution
scripts/setup.sh
ZPM_VERSION uses BENCH_ZPM_VERSION when set. The default canary fetch uses silent, fail-on-error curl options.
Workflow version and artifact controls
.github/workflows/benchmark.yaml
The workflow sets BENCH_ZPM_VERSION to 6.0.0-rc.20. Benchmark and version artifacts upload only when the run is not cancelled.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: jdx

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: pinning the Yarn canary benchmark to an ARM64 release that is available.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lukekarrys
lukekarrys enabled auto-merge (squash) September 21, 2026 22:05
@lukekarrys
lukekarrys merged commit aff8423 into main Sep 22, 2026
57 checks passed
@lukekarrys
lukekarrys deleted the fix/yarn-arm64-canary branch September 22, 2026 00:50

This branch was successfully deployed

1 active deployment
Benchmark — 76cedbce Deployed Sep 21, 2026 by lukekarrys via Run Benchmarks (svelte, ci) #1288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants