Repository navigation
Conversation
…paths Cut cases that only add a cold JIT compile or repeat coverage held elsewhere, so the suite fits a 4-GPU CI budget: - transport: keep 2F2A in BF16 and FP8 plus 1F3A in FP8 (pairwise topology x payload, as test_two_lanes_dbo_order already does). - Attention TP: keep 2F-1DPx2TP in FP8; drop the 6-GPU 2F-2DPx2TP cases. The per-DP-rank split over TP peers is covered on CPU by test_tokens_per_attention_rank_splits_each_dp_rank_over_its_tp_peers. - drop test_transport_with_fused_experts_backend: every FFN check already runs the fused_experts reference. - drop test_fp8_without_host_sync_for_small_buckets: the *_nosync standard cases skip the host sync with worst-case shapes, and the threshold, ladder and precompile rules are unit-tested. - drop test_graph_and_eager_plans_mixed_across_ranks and its harness helpers: the FFN eager fallback keeps Attention's replay flag, so the ranks plan a step alike; the bucket invariant stays unit-tested. - fold test_dbo_pipeline_cuda_graph_capture_and_replay into test_dbo_graph_capture_reuses_sent_rows, which runs the same captured DBO scenario with full checks before its memory-growth check. - run test_close_cancels_a_blocked_control_receive on 2F2A so it reuses the compiled kernels, and check every FFN rank. - drop the peer-exit wall-clock assertion; run_ranks already reports ranks alive at the budget as hung. Sync tests/gpu/README.md and the comments that cited removed cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
ronenkat
requested review from
hsliuustc0106 and
jiangkuaixue123
as code owners
November 15, 2026 08:55
Collaborator
Author
|
FYI @Etelis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make
tests/gpu/test_deepep_m2n_gpu.pyfit a 4-GPU CI budget. A cold run isdominated by the DeepEP/DeepGEMM JIT compile of each new kernel configuration,
so this removes cases whose only contribution is another compile or coverage
held elsewhere. 35 cases become 23, and none needs more than 4 GPUs.
Issue
Scope
tests/gpu/test_deepep_m2n_gpu.py,tests/gpu/deepep_m2n_harness.py,tests/gpu/README.md; comment-only edits indeepep_m2n/connector.pyandtests/unit/connectors/test_deepep_m2n_connector.py.Implementation Notes
Removed cases:
test_attention_tp_peers_dispatch_disjoint_slices2F-2DPx2TP-bf16,2F-2DPx2TP-fp8(6 GPUs),2F-1DPx2TP-bf162F-1DPx2TPFP8. The per-DP-rank split over TP peers is CPU logic, covered bytest_tokens_per_attention_rank_splits_each_dp_rank_over_its_tp_peers.test_transport_and_deepgemm_experts1F1A-bf16,1F1A-fp8,1F3A-bf16test_two_lanes_dbo_order).test_transport_with_fused_experts_backendfused_expertsas the reference.test_fp8_without_host_sync_for_small_buckets*_nosyncstandard cases skip the host sync with worst-case shapes; the threshold, ladder and precompile rules are unit-tested.test_graph_and_eager_plans_mixed_across_ranksmixed_mode_casesandffn_graph_modein the harnesstest_dbo_pipeline_cuda_graph_capture_and_replaytest_dbo_graph_capture_reuses_sent_rowsruns the same captured DBO scenario with full checks first.Other changes:
test_close_cancels_a_blocked_control_receiveruns on 2F2A (reusescompiled kernels) and checks every FFN rank; the peer-exit wall-clock assertion is
dropped (
run_ranksalready reports ranks alive at the budget as hung).Test Plan
pytest tests/unitandpytest -m "not gpu and not vllm_runtime" tests/unitpytest -sv -m gpu tests/gpu/test_deepep_m2n_gpu.pyon 4 GPUs, cold then warm JIT cachesTest Result
vLLM 0.32.0, torch 2.13.0+cu130, afdEP-comm v1.1.0, DeepGEMM 2.8.2 (5081f85), 4x H200.
Both failures (
test_npu_feature_validation[gate-on-attention],[async-graph])also fail on main 6620336 and are unrelated.
tests/gpu/test_deepep_m2n_gpu.py): 23/23 passed with cold JIT caches(17.8 min; the old 35-case suite took 32.1 min cold on the same 4x H200 setup)
and 23/23 with warm caches (5.4 min).
Docs Impact
tests/gpu/README.md(GPU requirement, case count, test table).