Repository navigation
Conversation
The connector-local compatibility flag and the unknown-quant-mode case sat behind ``pytest.importorskip(vllm)`` although they only need the module to import: ``camp2p`` pulls ``vllm.forward_context`` at module scope, nothing at call time touches vLLM. They were therefore the two cases a bare CPU host never ran, and the connector-level contract they pin is exactly what vllm-project#581 tripped over. The helper now stubs the handful of runtime modules the import needs, restores ``sys.modules`` afterwards, and returns the real ``CAMP2PExtraInfo``; parsing and validation stay real. Local run: 11 passed (previously 9 passed, 2 skipped). Signed-off-by: 宋元盟 <songyuanmeng2@huawei.com>
Pingzii
requested review from
hsliuustc0106 and
jiangkuaixue123
as code owners
November 14, 2026 17:07
Contributor
Author
|
Folded into #583 as the third commit ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the two connector-contract cases from #503 run on a bare CPU host.
test_sync_gate_feature_validation_cpu.pyhad 9 cases running everywhere and 2 behindpytest.importorskip("vllm"): the connector-localcompute_gate_on_attentioncompatibility flag and the unknown-quant-mode rejection. They do not need vLLM at call time --camp2ponly pullsvllm.forward_context(and a few siblings) at module scope -- so the skip hid exactly the contract that tripped #581._real_extra_info()now installs the handful of runtime modules the import needs, restoressys.modulesafterwards, and returns the realCAMP2PExtraInfo: parsing and validation stay production code, only the unavailable imports are stood in. On a host with vLLM installed the import simply succeeds and nothing is stubbed.Local Windows CPU run: the file goes from
9 passed, 2 skippedto11 passed; fulltests/unitis922 passed, 90 skipped, 0 failed.Follow-up, not done here:
test_sync_attention_gate_proxy.pyalso needs vLLM-Ascend andtest_camp2p_connector.pyneedstorch_npu, so those stay CI-only and their per-file execution/skip record is the thing to read, not the suite total.