Repository navigation
font: keep every installed symbol family in the fallback chain, capped - #93
Merged
Merged
Conversation
The installed slot stopped at the first family that resolved, so a machine with Noto Sans Symbols 2 spent it on a face that has no arrows: Noto Sans Symbols 2 does not cover U+2190-2193, and the shortcut labels drew glyph 0. Walk every family against the machine instead, up to font_symbol_path_limit of 5 faces, so the rebind load and the per-miss fallback walk stay bounded while the arrow-bearing families behind the dingbat-covered one still join the chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installed slot stopped at the first family that resolved, so a machine with Noto Sans Symbols 2 spent it on a face that has no arrows: Noto Sans Symbols 2 does not cover U+2190-2193, and the shortcut labels drew glyph 0. Walk every family against the machine instead, up to font_symbol_path_limit of 5 faces, so the rebind load and the per-miss fallback walk stay bounded while the arrow-bearing families behind the dingbat-covered one still join the chain.