Repository navigation
Cover vails menu and tray scenarios on the Windows backend - #57
Merged
Merged
Conversation
diiviocity
force-pushed
the
feat/menu-tray-vails-scenarios
branch
from
October 21, 2026 06:59
f4f9397 to
22676f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests only. I gap-checked the menu bar and tray against what an embedder needs
and found no code gap, so this adds no API.
Windows scenarios covered, in
menu_tray_test.vat the repository root (see thenative_window_handlePR for why the tests live there):set_menu_bartwice, the second declarationwins
right-click emits nothing
Plus a portable test that
set_menu_bar/menu_barround-trip the declaration,which is what keeps this file valid on the backends where the Windows block
compiles out.
Verification
-checkpasses for windows native/custom, linux native/custom, androidnative/custom. The file runs green on Windows, natively and with
-d ui2_custom_rendering. macOS and iOS are not verified — no macOS hosthere.
CI is red on this branch for the pre-existing
ui/chart.vint/float issuedescribed in the
native_window_handlePR, not for anything here.