Skip to content

build: stop excluding Windows ports from the collective build - #256

Open
metif12 wants to merge 2 commits into
vlang:mainfrom
metif12:un-ignore-windows-ports
Open

metif12 wants to merge 2 commits into
vlang:mainfrom
metif12:un-ignore-windows-ports

Conversation

@metif12

@metif12 metif12 commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

The Windows ignore_dirs list documented what Win32 GNU coreutils 8.32 ships, not what this repository cannot build. Three tools that were listed — ls, sync and timeout — compile and pass their tests on Windows, so the Windows CI job never built them at all, which is how the timeout bug that only broke Linux and macOS survived until someone diagnosed #237.

The list is now what this repository genuinely cannot build on each platform, so those three are removed.

The df, dir, vdir, install, nice and chmod ports also build on Windows and are removed too, but they only exist on open PRs, so they will not be built until those merge. That is a sequencing consequence rather than a mistake, stated here so nobody reads this commit as claiming six more tools are covered on Windows today.

Verified: the collective build compiles 76 tools, and v test src/ls src/sync src/timeout passes 4/4 test files.

The Windows ignore_dirs list documented what Win32 GNU coreutils 8.32 ships, not what this repository cannot build. Three tools that were listed — ls, sync and timeout — compile and pass their tests on Windows, so the Windows CI job never built them at all, which is how the timeout bug that only broke Linux and macOS survived until someone diagnosed vlang#237. The list is now what this repository genuinely cannot build on each platform, so those three are removed. The df, dir, vdir, install, nice and chmod ports also build on Windows and are removed too, but they only exist on open PRs, so they will not be built until those merge; that is a sequencing consequence rather than a mistake, and it is stated here so nobody reads this commit as claiming six more tools are covered on Windows today.
@metif12
metif12 force-pushed the un-ignore-windows-ports branch from 2342e1a to 04db685 Compare October 17, 2026 10:52
@metif12

metif12 commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Dropped the 'vinix': ['uptime'] entry that was duplicating #250's.

Both this branch and #250 added that line to the per-platform exclusion map in build.vsh, at the same place, so they conflicted:

CONFLICT (content): Merge conflict in build.vsh

Vinix is not this PR's subject — the change here is about the Windows exclusion list, where tools this repo already builds and tests for Windows were being skipped. Adding a platform entry is #250's job and it carries the reasoning for why only uptime is excluded there, which is worth keeping in full.

So this branch's diff is now only the exclusion-list change it was always about, build.vsh and nothing else, and the two PRs merge in either order. I checked with git merge-tree: clean with #250 both ways.

If #250 lands first this branch rebases to a no-op on that file. If this lands first, #250's commit still supplies the vinix entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant