Repository navigation
fix(tests): governance suite no longer depends on the box's own Claude login (v0.469.5) - #900
Merged
Merged
Conversation
…e login (v0.469.5) Launch-path tests isolated AGENT_OS_HOME but not ~/.claude, so the credential pre-flight read the machine's real default login. instawp's had long been dead, so launch-window-test saw a refused launch and the deploy gate blocked a correct build. Run the chain under a scratch CLAUDE_CONFIG_DIR with a placeholder credential. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make-live.shblocked the v0.469.4 deploy on instawp:launch-window-testsawsession.launch.refused(dir: /home/ubuntu/.claude,expiredAt: 0). The box's default Claude login is dead (no tokens, refresh expired 2026-10-27). That's harmless in production, since every real run uses a pool account. But the launch-path tests isolateAGENT_OS_HOME, not~/.claude, so the credential pre-flight was checking the machine's own login.npm run test:governancenow runs the unchanged chain (moved totest:governance:run) throughscripts/governance-isolated.cjs, which sets a scratchCLAUDE_CONFIG_DIRholding a well-formed placeholder credential. Tests that set their ownCLAUDE_CONFIG_DIRstill override it.Verified: before the fix,
launch-window-testwith a deadCLAUDE_CONFIG_DIRgave 6 failures. After it, the fullnpm run test:governanceunder a dead outerCLAUDE_CONFIG_DIRpasses with 0 failures.🤖 Generated with Claude Code