test(historical): B1 — characterization golden + reader-level parity oracle (#126) - #128
Merged
Merged
Conversation
…level parity oracle (#126, Feathers amendment) 400-row real slice (2 months x 200 cells) through the FULL legacy chain (PGMDataset + pandas GAUL enrichment + join), captured to a committed golden BEFORE that chain is retired. Parity oracle mirrors faoapi's reader semantics (index restore-or-set; 9 non-null metadata columns; targets auto-detected) — future builders must match the reader-visible frame, never the bytes. Captured hazard, pinned: the legacy chain ships junk 'row'/'col' columns that faoapi would auto-detect as targets; the frame-native builder must drop them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part B story 1 of the run-0 OOM fix (expert review: Feathers amendment — capture the oracle BEFORE retiring the legacy chain).
tests/test_historical_parity.py: reader-level oracle mirroring faoapi's actual reader semantics (dataset_service.py:255-334,handlers.py:1365-1417) — future builders compared on the reader-visible frame, not bytes.row/colcolumns that faoapi's auto-detect would serve as bogus targets — the frame-native builder (next story) drops them deliberately.A2 measurements for the record: streamed forecast leg on the REAL run = 4.73 GB peak, 108 shards, 5 min, zero uploads; legacy historical leg could not finish its 28.3M-row join within 500 s (after previously OOM-killing at 23.8 GB) — Part B is confirmed critical-path for run 0.
Refs #126. 🤖 Generated with Claude Code