Skip to content

Use wrangler pages deploy instead of the deprecated pages publish - #8114

Merged
robwalch merged 1 commit into
video-dev:masterfrom
jasontd92:unstale/wrangler-pages-deploy
Oct 23, 2026
Merged

robwalch merged 1 commit into
video-dev:masterfrom
jasontd92:unstale/wrangler-pages-deploy

Conversation

@jasontd92

Copy link
Copy Markdown
Contributor

This PR will...

Replace wrangler pages publish with wrangler pages deploy in scripts/deploy-cloudflare.sh. The arguments stay the same.

Why is this Pull Request needed?

With the installed wrangler 4.151.0, pages publish is a deprecated alias for pages deploy. The cloudflare_pages job prints this warning on every master build (for example, run 39840551384):

▲ [WARNING] `wrangler pages publish` is deprecated and will be removed in the next major version.
  Please use `wrangler pages deploy` instead, which accepts exactly the same arguments.

In wrangler's source, pages publish uses the same command definition as pages deploy. The only extra thing it does is log that warning (packages/wrangler/src/pages/deploy.ts). The current pages deploy docs list the flags the script uses: --project-name, --branch, --commit-hash and --commit-dirty. Switching now means the deploy keeps working when Renovate brings in the next wrangler major.

Are there any points in the code the reviewer needs to double check?

I couldn't run an actual deploy, because that needs the Cloudflare token. Verification was done in a node:24-bookworm container after npm ci --ignore-scripts, on master first and then on this branch:

  • bash -n scripts/deploy-cloudflare.sh passes on both.
  • wrangler pages publish --help and wrangler pages deploy --help list the same positionals and options. Only the command name and description lines differ.
  • I ran both commands with the script's arguments (--project-name x --commit-dirty=true --branch=master --commit-hash=0000000 <empty dir>, CI=true, no token). Both parse the arguments and stop at the same CLOUDFLARE_API_TOKEN required error. Only publish prints the deprecation warning.

Resolves issues:

None filed.

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable): not applicable, deploy script only
  • API or design changes are documented in API.md: no API change

Found with unstale, a tool I'm building so nobody has to read every changelog to catch changes like this one. Prepared with AI assistance (Claude Code) and verified as described above.

@robwalch robwalch added the CI label Oct 23, 2026
@robwalch
robwalch requested a review from tjenkinson October 23, 2026 19:38
@robwalch robwalch added this to the 1.7.4 milestone Oct 23, 2026
@robwalch
robwalch merged commit 98d7fc8 into video-dev:master Oct 23, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from Top priorities to Done in HLS.js Release Planning and Backlog Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants