Repository navigation
Make subtitle-stream-controller tracksBuffered a sparse array - #8108
Merged
robwalch merged 1 commit intoOct 22, 2026
Merged
Conversation
robwalch
deleted the
enhancement/subtitles-sparse-track-buffered-ranges
branch
October 22, 2026 00:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will...
tracksBuffereda sparse array.Why is this Pull Request needed?
Follow-up to review nit-picks #8077 (review) to remove the need to iterate through subtitle tracks on detach.
The
frag.end === bufferedInfo.endcheck exits fragment loading to prevent reloading of segments removed from the fragment tracker track switch, but which remain as track cues with buffered ranges intracksBuffered.Are there any points in the code the reviewer needs to double check?
Resolves issues:
Follow-up to #8077
Checklist