Skip to content

Make subtitle-stream-controller tracksBuffered a sparse array - #8108

Merged
robwalch merged 1 commit into
masterfrom
enhancement/subtitles-sparse-track-buffered-ranges
Oct 22, 2026
Merged

robwalch merged 1 commit into
masterfrom
enhancement/subtitles-sparse-track-buffered-ranges

Conversation

@robwalch

@robwalch robwalch commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

This PR will...

  • Make subtitle-stream-controller tracksBuffered a sparse array.
  • Do not reload last segment after re-attach.

Why is this Pull Request needed?

Follow-up to review nit-picks #8077 (review) to remove the need to iterate through subtitle tracks on detach.

The frag.end === bufferedInfo.end check exits fragment loading to prevent reloading of segments removed from the fragment tracker track switch, but which remain as track cues with buffered ranges in tracksBuffered.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Follow-up to #8077

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.7.4 milestone Oct 21, 2026
@robwalch
robwalch requested a review from matvp91 October 21, 2026 22:49
@robwalch
robwalch merged commit fc77012 into master Oct 22, 2026
16 checks passed
@robwalch
robwalch deleted the enhancement/subtitles-sparse-track-buffered-ranges branch October 22, 2026 00:10
@github-project-automation github-project-automation Bot moved this from Top priorities to Done in HLS.js Release Planning and Backlog Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant