Repository navigation
Let the compliance suite verify the ledger anchor - #37
Merged
Merged
Conversation
Opt-in config.compliance_anchored runs LedgerChain anchored in the suite. Not inferred from ledger_anchor, so a suite never publishes to an anchor it was not told to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A new opt-in setting lets the compliance suite prove the ledger anchor works: with it on, the suite's ledger check makes a checkpoint, sends it to the configured anchor, reads it back, and verifies against it. Before, this needed a separate hand-written test. Off by default, so existing suites behave the same and never publish to an anchor they were not told to use. The README's CI section now shows the setting instead of the hand-written test.
Testing
Full suite green on SQLite, rubocop clean; CI covers PostgreSQL and MySQL.
ledger_anchorat a scratch file and setcompliance_anchored = true.config.ledger_anchor.compliance_anchoredback to false: the check passes and the anchor file is not touched.