Repository navigation
Phase 31 slice F: overlay rules - #250
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice F of Phase 31 (docs/specs/PHASE-31-SPEC.md, FR-F1): the overlay rules. A new desktop-app rule,
desktop-app-overlay, flags overlays that cannot work as drawn. The spec's "Slice F — contracts pinned before build" block (S8, M1 to M8) records the contracts. The "Slice F — as built" block (N1 to N4) records the corrections found while building and every fix from verification.What changes
modalon one canvastooltipwith children, which never renderoverflow: "auto"that renders wider than the modal or scrolls sidewayspopoverormenuon a canvas that holds amodalor adrawerwithscrim: true(spec change S8). Popovers and menus stack at 400, under the scrim at 500, so they show dimmed behind the dialog.toasttoastwithtone: "danger"(put the error inline or in a banner)anchorthat names no node, or a node that is not a clickable primitive or controlx,y,widthandheight, and a placed modal's left, right and top edges. Tooltips and toasts size to their text and drawers are pinned right, so they are left to detailed mode.batch_designoverlay section, thecanvas_evaluatedocstring, the rule and overlay sections ofdocs/GUIDELINES.md, the README rule table and overlay paragraph, and VISION.md.Decisions worth a look
scrim: true, for the same reason.isHeaderRowtest, so eleven such rows count as ten.widthto its parent (max-width: 100%). So fast mode reads only aminWidth, or awidthwhosemaxWidthlets it stay wider, as wider than a modal.maxWidthis read as CSS reads it: px, % and vw cap it;"none"and a negative value leave it uncapped; any other unit is read as the parent. The pinned contract compared the barewidth, and N1 records the correction.x,y,widthandheight. A tooltip and a toast ignore an authoredwidth, and a modal's height is its content. So fast mode warned on clean screens. A test now runs ten scenes in both modes and asserts the verdicts agree.Testing
test-desktop-app-overlay.ts(fast) covers:list-detail-app(confirm-deleteandcomment-open), which raise no blocking finding of any rule, plus a failing twin of eachtest-desktop-app-overlay-detailed.ts(Chrome) covers:maxWidthwas a false positive in fast mode.npm run test:full: 132/132 on e9ce434. The last commit only corrects two comments;npm testgives 88/88 on it, and the detailed overlay test passes.