Repository navigation
Fix: service stop hangs ~30 s while a dashboard is open - #131
Merged
Merged
Conversation
The /ws/seats read loop ignored shutdown, so Kestrel waited out its full grace period (~30 s) for any open dashboard socket before the service could stop. The loop now ends when the host starts stopping and closes the socket. A new test fails at 30.0 s on the old code and passes in about 0.1 s now. Also document that SteamLauncher -shutdown exits 0 once it hands the request to Steam, and that Steam will not exit while a game is running in that seat. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: service stop hangs ~30 s while a dashboard is open
On 2026-10-21 the service took about 31 s to stop during the 0.6.23 install. The Event Log showed a 28 s silent gap after "Input router stopped".
The
/ws/seatsread loop ignored shutdown, so Kestrel waited out its full grace period for any open dashboard socket. The loop now stops when the host stops and closes the socket.WebSocketShutdownTests, opens a dashboard socket and timesStopAsync. It fails at 30.0 s on the old code and passes in about 0.1 s with the fix.SteamLauncher -shutdownexits 0 once it hands the request to Steam, and that Steam will not exit while a game is running in that seat.🤖 Generated with Claude Code