Skip to content

fix(hub): use canonical agent delivery lifecycle - #14

Merged
jack-arturo merged 3 commits into
mainfrom
fix/canonical-agent-lifecycle
Sep 23, 2026
Merged

jack-arturo merged 3 commits into
mainfrom
fix/canonical-agent-lifecycle

Conversation

@autojack-bot

@autojack-bot autojack-bot Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Hub-backed cottages now display the same canonical delivery state as Hub’s task inventory. The adapter preserves PR evidence, finalization, cleanup, current result, and execution duration; it no longer overrides those observations with independent GitHub polling. Standalone discovery keeps its existing GitHub adapter.

Ready tasks remain idle with “Ready for merge,” blocked tasks stay blocked, and failed/cancelled work no longer appears successfully done. The PR desk uses Hub freshness, and removed worktrees retain their historical copy action without offering an invalid launch link.

Review contract

  • Hub-backed tasks use Hub PR state, current-head readiness, blockers, and freshness as authority; raw labels remain evidence.
  • Independent GitHub enrichment runs only for standalone discovery.
  • Task success, delivery state, and cleanup remain distinct. Recorded execution duration excludes review/merge wait.
  • Existing town rendering, standalone sources, and explicit message permissions are preserved.

Verification

  • npm test: 348 passed after synchronizing the viewport/compact-map base.
  • npm run test:browser: real-Chrome journey passed, including PR metadata, reconnect recovery, responsive layout, and canonical inventory/history stability.
  • Actual production CottageCode at localhost8787, reading Hub8767, showed the same #1757 parent as completed/merged with passing CI and safely deferred cleanup; PR-desk screenshot and DOM assertions captured.
  • API/browser normalization tests cover stale verified readiness, changed-head blockers, duration after merge, failed outcomes, and removed-worktree controls.

Canonical Hub dependency: https://github.com/verygoodplugins/autohub/pull/1764. Related incident: verygoodplugins/autohub#1757. Requires canonical Hub metadata for the additional lifecycle display; absent evidence stays unknown.

Implementation harness: Codex desktop. GitHub identity: AutoJack GitHub App.

@autojack-bot
autojack-bot Bot requested a review from jack-arturo as a code owner September 22, 2026 23:46
@autojack-bot autojack-bot Bot added babysit:active Babysit agent is actively working this PR babysit:waiting-codex 👀 Codex reviewing current head and removed babysit:active Babysit agent is actively working this PR labels Sep 22, 2026
@jack-arturo

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T00:02:28.000899Z 8d76c93 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d76c932ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/pr.mjs Resolved
@autojack-bot

autojack-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Babysit handoff — verified green at 5cf4d47855fef34f9897c884b4cadf296f2d02a1.

  • CI smoke passed on this exact head; local npm test passed 330 tests.
  • Hosted Codex reviewed baseline 8d76c932ba. Its standalone-readiness finding was explained and resolved against the approved Hub-authority contract and existing regressions.
  • The only later change clarifies AGENTS documentation. The 10-minute passive auto-review grace expired with no active review; Codex did not select that documentation head for another review.
  • No active unresolved Codex threads remain. The PR is open, non-draft, mergeable, and its head matches the pushed commit. Size: 195 changed lines.
  • Production CottageCode was verified against the same canonical #1757 parent as the TUI. Hub dependency: verygoodplugins/autohub#1764.

Ready for human merge. No merge performed.

Implementation/babysit harness: Codex desktop. Ordinary GitHub writes: AutoJack App. Repository-wide label normalization was omitted; label changes were scoped to this PR.

@autojack-bot autojack-bot Bot added babysit:ready 👍 Codex all clear + gates pass; human may merge babysit:active Babysit agent is actively working this PR and removed babysit:waiting-codex 👀 Codex reviewing current head babysit:ready 👍 Codex all clear + gates pass; human may merge labels Sep 23, 2026
@autojack-bot autojack-bot Bot added babysit:waiting-ci Babysit waiting for CI checks on current head babysit:waiting-codex 👀 Codex reviewing current head and removed babysit:active Babysit agent is actively working this PR babysit:waiting-ci Babysit waiting for CI checks on current head labels Sep 23, 2026
@autojack-bot

autojack-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Babysit handoff — verified green at 3afbf83d8167847c3f0f149d85602fa31bb7c278.

PR: fix(hub): use canonical agent delivery lifecycle
Branch: fix/canonical-agent-lifecycle

The viewport/compact-map base update is synchronized. The sole overview-rendering conflict retains the canonical lifecycle panel alongside all base changes. Hub remains the authority for readiness and freshness.

  • npm test: 348 passed. Syntax and diff checks passed.
  • npm run test:browser: the real-Chrome journey passed, including PR metadata, reconnect recovery, responsive layout, and canonical inventory/history stability.
  • Exact-head CI smoke: SUCCESS — https://github.com/verygoodplugins/cottagecode/actions/runs/35808951864/job/107015909608.
  • Hosted Codex baseline 8d76c932ba was reviewed and its thread resolved. The later-head 10-minute passive grace has expired without another selected review or active eyes signal; this is policy-settled, not an explicit current-head review.
  • Final head matches the pushed commit; the PR is open, non-draft, MERGEABLE, and has no active unresolved Codex findings. Size remains 195 changed lines.

Ready for human merge. No merge or auto-merge performed. Primary repositories were untouched during this base synchronization. No additional manual Codex review request was posted.

Implementation/babysit harness: Codex desktop; ordinary GitHub writes use the AutoJack App.

@autojack-bot autojack-bot Bot added babysit:ready 👍 Codex all clear + gates pass; human may merge and removed babysit:waiting-codex 👀 Codex reviewing current head labels Sep 23, 2026
@jack-arturo
jack-arturo merged commit 5fc4b6f into main Sep 23, 2026
1 check passed
@autohub-codex autohub-codex Bot removed the babysit:ready 👍 Codex all clear + gates pass; human may merge label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant