Repository navigation
feat(cli): launch throwaway browsers from the one connected to the relay - #36
Merged
Merged
Conversation
Search reports itself as Chrome in the extension user-agent, so browser-path and doctor prefer the name in the debugger stub and resolve that macOS app.
browser-path now records a bundle only after its name matches, and the remote-debug recipe resolves the executable before the connected browser is quit.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jack-arturo
added
babysit:active
Member
Author
|
Babysit ready. Verified green at Codex signed off this head with 👍 (settled by reaction; review state completed with no findings). No review threads. CI is green on all six checks. The agent did not merge. |
jack-arturo
added
babysit:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Throwaway launches were still aimed at Chrome.
browser-hand browser-pathreads the relay and returns the macOS executable of the browser that actually has the extension connected. If nothing is connected, it fails. It does not fall back to Chrome or the OS default browser.Search's extension user-agent still says Google Chrome. The debugger stub says the host is Search, and that name wins for
browser-pathanddoctor.Test plan
cd cli-js && node --test test/*.test.js— 224 pass, including the alias-ordering casebrowser-hand browser-pathagainst Search returned/Applications/Search.app/Contents/MacOS/Searchdaemon/andcli/are untouchedNotes for reviewers
/Applications, then~/Applicationsonly when the first directory has no match. Several matches are an error, not a guess.browser-pathwill not answer.cli-js.Local review (Codex
gpt-6.1-sol, medium) fixed the alias-ordering miss and the recipe order before this PR opened. A follow-up note about fixture tests callingplutilwas not applied: the command is macOS-only, and CI does not runcli-jstests.Implementation harness: Cursor (Grok 4.7). GitHub identity: the operator's
ghlogin; this session has no GitHub App token.