Skip to content

Backport #2713: fix(nitro): use workspaceDir for monorepos#2720

Merged
NathanColosimo merged 1 commit into
stablefrom
backport/pr-2713-to-stable
Jul 1, 2026
Merged

Backport #2713: fix(nitro): use workspaceDir for monorepos#2720
NathanColosimo merged 1 commit into
stablefrom
backport/pr-2713-to-stable

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Automated backport of #2713 to stable (backport job run).

AI recommendation: This is a self-contained bug fix to existing functionality that exists on stable: the nitro builders.ts structure, createBaseBuilderConfig's projectRoot option, and the affected test files (packages/nitro/src/index.test.ts, packages/core/e2e/dev.test.ts) all already exist on stable. The docs changes are in docs/content/ (maintained on stable) and the e2e test-stabilization tweaks apply to existing tests, so the whole commit should backport cleanly.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.

@github-actions
fix(nitro): use workspaceDir for monorepos (#2713)
7a198bf 
* fix(nitro): use workspaceDir for monorepos

* test: stabilize Next canary HMR e2e

Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@github-actions github-actions Bot requested review from a team and ijjk as code owners June 30, 2026 20:48
@github-actions github-actions Bot mentioned this pull request Jun 30, 2026
Merged
@changeset-bot

changeset-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7a198bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/nitro Patch
@workflow/nuxt Patch
workflow Patch
@workflow/world-testing Patch
@workflow/core Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/next Patch
@workflow/vitest Patch
@workflow/web-shared Patch
@workflow/web Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Jun 30, 2026 8:52pm
example-nextjs-workflow-webpack Ready Ready Preview, Comment Jun 30, 2026 8:52pm
example-workflow Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workbench-astro-workflow Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workbench-express-workflow Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workbench-fastify-workflow Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workbench-hono-workflow Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workbench-nitro-workflow Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workbench-nuxt-workflow Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workbench-sveltekit-workflow Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workbench-tanstack-start-workflow Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workbench-vite-workflow Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workflow-docs Ready Ready Preview, Comment, Open in v0 Jun 30, 2026 8:52pm
workflow-swc-playground Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workflow-tarballs Ready Ready Preview, Comment Jun 30, 2026 8:52pm
workflow-web Ready Ready Preview, Comment Jun 30, 2026 8:52pm

@NathanColosimo NathanColosimo enabled auto-merge (squash) June 30, 2026 21:37
@github-actions

github-actions Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

🧪 E2E Test Results

❌ Some tests failed

Summary

Passed Failed Skipped Total
✅ ▲ Vercel Production 1077 0 78 1155
✅ 💻 Local Development 1174 0 86 1260
✅ 📦 Local Production 1174 0 86 1260
✅ 🐘 Local Postgres 1162 0 98 1260
✅ 🪟 Windows 105 0 0 105
❌ 🌍 Community Worlds 80 101 9 190
✅ 📋 Other 592 0 38 630
Total 5364 101 395 5860

❌ Failed Tests

🌍 Community Worlds (101 failed)

redis (18 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KWD7GZ43SRRK2X04ZTYGBCFV
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KWD7HD2KH21GF805HZ3KE6PR
  • sleepingWorkflow | wrun_01KWD7JPPWZWBDA887PC4KV93Z
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KWD7VB61EZ1NVF2B558J3Y2Y
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KWD7VR8XRN4V8BD219QF8M3R
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KWD7W1JQHZ7N3DDTCEHDT0GX
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KWD7WGXXRPGKGFQGG1P3YC8S
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KWD7XD19R4E8E8WKWHQJ1NEX
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KWD7XJMK0XV7WS1SSNT0FZRK
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KWD7XTKE452SSGET3H9GJZJM
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KWD7Y1984J257Z9FY9QQG264
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KWD7YAVGZPC481272B8G6WCB
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KWD84T8YCMF81K8S9A0XZ8HH

turso (83 failed):

  • addTenWorkflow | wrun_01KWD7FMXFSXR406G74ZWDBYTM
  • addTenWorkflow | wrun_01KWD7FMXFSXR406G74ZWDBYTM
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KWD7FZNJPMW1AFV61CS2M4MJ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KWD7FXBMRN8XD05XAHX3ZCSD
  • promiseRaceWorkflow | wrun_01KWD7G3G7MSHGV8FDKCGFDFGX
  • promiseAnyWorkflow | wrun_01KWD7G5ZQVYQTN2GPT1SEKSQM
  • importedStepOnlyWorkflow | wrun_01KWD7GD71RYTP8VK5PFZT5WFZ
  • readableStreamWorkflow | wrun_01KWD7GATMTQNEBF09QWWRRDGX
  • hookWorkflow | wrun_01KWD7GQNA8XKXQ5ETSEP4T6K7
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KWD7GZ43SRRK2X04ZTYGBCFV
  • webhookWorkflow | wrun_01KWD7H71XF8X1XVKMHCT28Q7D
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KWD7HD2KH21GF805HZ3KE6PR
  • sleepingWorkflow | wrun_01KWD7JPPWZWBDA887PC4KV93Z
  • parallelSleepWorkflow | wrun_01KWD7K6VE2JEY3EARPWTN3FR1
  • sleepWinsRaceWorkflow | wrun_01KWD7KC24GJ00ZXCCCHCWYN9K
  • stepWinsRaceWorkflow | wrun_01KWD7KFQQ1MM1ZJT41V2J8JVY
  • nullByteWorkflow | wrun_01KWD7KK9X1P1100P7B53MDQPY
  • workflowAndStepMetadataWorkflow | wrun_01KWD7KNM130SJG3H7JF0FKK2T
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KWD7PD2QK54JMRA9WHSN3AYE
  • writableForwardedFromWorkflowWorkflow | wrun_01KWD7PWG7XK1NVBP6W32C3CQW
  • writableForwardedFromStepWorkflow | wrun_01KWD7Q2F6KCD68VX9DDXM0HRG
  • fetchWorkflow | wrun_01KWD7Q62EK4K0W0EJXPWT6RWG
  • promiseRaceStressTestWorkflow | wrun_01KWD7Q9JHRCDQKNGAM9RRK3AF
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KWD7TXK6Q8Y97HVJCF67XMS6
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KWD7VB61EZ1NVF2B558J3Y2Y
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KWD7VR8XRN4V8BD219QF8M3R
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01KWD7VV7W37G9YY5H93R2JVGD
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01KWD7VXR76C1CBWWJ49B8T1Y2
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KWD7W1JQHZ7N3DDTCEHDT0GX
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KWD7WGXXRPGKGFQGG1P3YC8S
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KWD7XD19R4E8E8WKWHQJ1NEX
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KWD7XJMK0XV7WS1SSNT0FZRK
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KWD7XTKE452SSGET3H9GJZJM
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KWD7Y1984J257Z9FY9QQG264
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KWD7YAVGZPC481272B8G6WCB
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KWD7YKYQP77QY6690TS93GYE
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KWD7Z4W0KMG13DBRZQ9J9SQV
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KWD7ZEY7ZBM59H2C7XSQWYA1
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KWD7ZP478QKKC144TT45YF7J
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KWD7ZRQGP7EXEAKMWATVBW15
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KWD80ACED8RH80V256GD0HQP
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KWD80GQ3CP06E0T9412YBT1C
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KWD80SF68KASD2GB1G2GRAWY
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KWD811VM9BW42XRBDG5NVE6S
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KWD81932058Y836ZP2VBVRHV
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KWD81J1W5PXYN822FPANSP7V
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KWD81TPTY8MK7G2DQD2T61TB
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KWD82A78MYTBM0RJ6PZGY6NR
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KWD82KX7R7CT151S25AZAMW0
  • cancelRun - cancelling a running workflow | wrun_01KWD82WV325XBYHRK4ETAFQKM
  • cancelRun via CLI - cancelling a running workflow | wrun_01KWD8333EG69E1D424HJCAK9X
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KWD83B7CF7WSBV4GJJ4WNZAY
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01KWD83S78FGDTYXW0BXVGT6ZQ
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KWD8430ZBEJA23DWPJN1BAKX
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KWD84DPG2WGERWVXQ54DHZCE
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KWD84N5EMR16DFQ4W2A55V3P
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KWD84QK2ZKKY10YZJ3DCNTNC
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KWD84T8YCMF81K8S9A0XZ8HH

Details by Category

✅ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 97 0 8
✅ example 97 0 8
✅ express 97 0 8
✅ fastify 97 0 8
✅ hono 97 0 8
✅ nextjs-turbopack 102 0 3
✅ nextjs-webpack 102 0 3
✅ nitro 97 0 8
✅ nuxt 97 0 8
✅ sveltekit 97 0 8
✅ vite 97 0 8
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 99 0 6
✅ express-stable 99 0 6
✅ fastify-stable 99 0 6
✅ hono-stable 99 0 6
✅ nextjs-turbopack-canary 86 0 19
✅ nextjs-turbopack-stable 105 0 0
✅ nextjs-webpack-canary 86 0 19
✅ nextjs-webpack-stable 105 0 0
✅ nitro-stable 99 0 6
✅ nuxt-stable 99 0 6
✅ sveltekit-stable 99 0 6
✅ vite-stable 99 0 6
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 99 0 6
✅ express-stable 99 0 6
✅ fastify-stable 99 0 6
✅ hono-stable 99 0 6
✅ nextjs-turbopack-canary 86 0 19
✅ nextjs-turbopack-stable 105 0 0
✅ nextjs-webpack-canary 86 0 19
✅ nextjs-webpack-stable 105 0 0
✅ nitro-stable 99 0 6
✅ nuxt-stable 99 0 6
✅ sveltekit-stable 99 0 6
✅ vite-stable 99 0 6
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 98 0 7
✅ express-stable 98 0 7
✅ fastify-stable 98 0 7
✅ hono-stable 98 0 7
✅ nextjs-turbopack-canary 85 0 20
✅ nextjs-turbopack-stable 104 0 1
✅ nextjs-webpack-canary 85 0 20
✅ nextjs-webpack-stable 104 0 1
✅ nitro-stable 98 0 7
✅ nuxt-stable 98 0 7
✅ sveltekit-stable 98 0 7
✅ vite-stable 98 0 7
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 105 0 0
❌ 🌍 Community Worlds
App Passed Failed Skipped
✅ mongodb-dev 3 0 3
✅ redis-dev 3 0 3
❌ redis 68 18 0
✅ turso-dev 3 0 3
❌ turso 3 83 0
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 99 0 6
✅ e2e-local-dev-tanstack-start-stable 99 0 6
✅ e2e-local-postgres-nest-stable 98 0 7
✅ e2e-local-postgres-tanstack-start-stable 98 0 7
✅ e2e-local-prod-nest-stable 99 0 6
✅ e2e-local-prod-tanstack-start-stable 99 0 6

📋 View full workflow run

@NathanColosimo NathanColosimo merged commit f927d69 into stable Jul 1, 2026
278 of 296 checks passed
@NathanColosimo NathanColosimo deleted the backport/pr-2713-to-stable branch July 1, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VaguelySerious VaguelySerious VaguelySerious approved these changes
@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious @NathanColosimo