-
Notifications
You must be signed in to change notification settings - Fork 295
fix(ai): recover from invalid tool-call input instead of aborting the agent stream #2192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
boomyao
wants to merge
4
commits into
vercel:main
from
boomyao:fix/durable-agent-recover-invalid-tool-input
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2549cd8
fix(ai): recover from invalid tool-call input instead of aborting the…
boomyao c045cdd
fix(ai): emit ai.toolCall span for recovered invalid tool input; test…
VaguelySerious 2462eca
Merge remote-tracking branch 'origin/main' into fix/durable-agent-rec…
VaguelySerious e2266dd
chore(changeset): condense to a single sentence
VaguelySerious File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@workflow/ai': patch | ||
| --- | ||
|
|
||
| DurableAgent now recovers from invalid tool-call input by returning the validation error to the model instead of aborting the stream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Review: Nit
This verifies the validation error is fed back as
error-text, but the mocked secondnext()returns{ done: true }, so it doesn't prove the agent productively recovers. Consider having the second turn return a corrected tool call and asserting the tool'sexecuteactually runs with the fixed input — that exercises the full "self-correct and retry within maxSteps" claim, not just the error-feedback half.