Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a component unmounts, styled-jsx removes its
<style>tag withtag.parentNode.removeChild(tag). If something else already took the tag out of the DOM (browser extensions, scrapers and screenshot tools that strip<style>tags),parentNodeisnulland this throwsTypeError: Cannot read properties of null (reading 'removeChild'). The throw happens during React's commit phase, so the whole tree falls back to the nearest error boundary.We see a few thousand of these a week in production, mostly from headless Chrome and some from real Chrome users with extensions.
This skips removal when the tag is already detached, in
StyleSheet.deleteRule,StyleSheet.flushandStyleSheetRegistry.remove(server-rendered tags). The bookkeeping (_tags[index] = null,delete this._fromServer[styleId]) still runs, so the sheet stays consistent.Added a test that detaches the tags before
deleteRuleandflush.