Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
erulkey
added this pull request to stack #388
October 14, 2026 19:35
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| } | ||
|
|
||
| export function gatewayKeyFingerprint(key: string) { | ||
| return createHash("sha256").update(key).digest("hex"); |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit choice for users who want to reuse their own Gateway key:
sandbox gateway setup, thensandbox create --ai --use-gateway-key codex. Setup creates or saves a key in the OS credential store. Explicit reuse readsAI_GATEWAY_API_KEYfirst, then the saved key; missing credentials fail with setup instructions.Plain
--aicontinues to request a managed session key and ignores local credentials. Personal keys stay outside the VM, remain bound to their existing sandboxes on reconnect, and are not revoked when one sandbox stops.The completed CLI stack passes 300 CLI tests and 81 SDK API-client tests. A built CLI check against an HTTP stub confirms managed issuance, explicit reuse, and failure without fallback. No new deployed managed lifecycle test is claimed.
Depends on vercel/sandbox#386.
Split from vercel/sandbox#382. Managed backend: vercel/api#98665.
CI is not green. CodeQL flags the SHA-256 hash in
gatewayKeyFingerprintas weak password hashing. This code fingerprints API keys for equality rather than validating passwords; the alert still requires security triage before merge.