Repository navigation
fix: finish the resumable stream when the source stream errors - #54
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53.
When the stream from
makeStream()errors,createNewResumableStreamnever handles the rejectedreader.read(). This causes an unhandled promise rejection, and the sentinel stays at"1"for the 24 h TTL. Resumed streams never getDONE_MESSAGE, and every laterresumeExistingStreamcall rejects withTimeout waiting for ack. The same thing happens if a Redis call in the read loop rejects.Changes
donecleanup into afinishfunction. It sets the sentinel toDONE, unsubscribes from the request channel, sendsDONE_MESSAGEto listeners, and resolves thewaitUntilpromise..catchto the read loop. On error, it cancels the source reader, errors the returned stream with the original error, and runsfinish.hasExistingStreamreturns"DONE", andresumeExistingStreamreturnsnull.Testing
REDIS_URL=redis://localhost:6379 npx vitest runError: source failed).