Use default pnpm package import method - #98703
Merged
Merged
Conversation
Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
Contributor
Tests PassedCommit: 78d7964 |
wbinnssmith
approved these changes
Sep 15, 2026
sokra
marked this pull request as ready for review
September 15, 2026 22:57
sokra
enabled auto-merge (squash)
September 15, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Use pnpm's default package import method in the two hoisted isolated-test configurations added by #98425.
Why?
package-import-methodcontrols how regular package files are materialized from pnpm's store: by reflink, hardlink, or copy. Those choices do not affectrealpath, so forcing copies is unrelated to the Node.js symlink-resolution workaround and unnecessarily disables pnpm's more efficient defaults.How?
Keep
node-linker=hoisted, which is the setting responsible for producing npm-style real package directories, while removing the independent copy policy. The Node-version gate, local-tarball validation, release-age policy, and fixture behavior remain unchanged.Verification
.bin, and a metadata-only.pnpmpnpm buildpnpm typesgit diff --checkFollow-up to #98425 and #98425 (comment).