Skip to content

Use default pnpm package import method - #98703

Merged
sokra merged 1 commit into
canaryfrom
codex/remove-pnpm-copy-workaround
Sep 15, 2026
Merged

sokra merged 1 commit into
canaryfrom
codex/remove-pnpm-copy-workaround

Conversation

@sokra

@sokra sokra commented Sep 15, 2026

Copy link
Copy Markdown
Member

What?

Use pnpm's default package import method in the two hoisted isolated-test configurations added by #98425.

Why?

package-import-method controls how regular package files are materialized from pnpm's store: by reflink, hardlink, or copy. Those choices do not affect realpath, so forcing copies is unrelated to the Node.js symlink-resolution workaround and unnecessarily disables pnpm's more efficient defaults.

How?

Keep node-linker=hoisted, which is the setting responsible for producing npm-style real package directories, while removing the independent copy policy. The Node-version gate, local-tarball validation, release-age policy, and fixture behavior remain unchanged.

Verification

  • Hoisted-only scratch install produced real package directories, no package symlinks outside .bin, and a metadata-only .pnpm
  • Production Turbopack: non-hoisted SWC helper and warm-restart task stats passed (2/2)
  • pnpm build
  • pnpm types
  • Prettier, ESLint, and git diff --check

Follow-up to #98425 and #98425 (comment).

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 78d7964

@sokra
sokra marked this pull request as ready for review September 15, 2026 22:57
@sokra
sokra enabled auto-merge (squash) September 15, 2026 22:57
@sokra
sokra merged commit f1285ce into canary Sep 15, 2026
118 checks passed
@sokra
sokra deleted the codex/remove-pnpm-copy-workaround branch September 15, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants