fix: handle aborted responses without unhandled rejections#168
Open
morgan-coded wants to merge 1 commit into
Open
fix: handle aborted responses without unhandled rejections#168morgan-coded wants to merge 1 commit into
morgan-coded wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client aborts could leave
mcp-handlerwith an unhandled rejection if the request handler or response builder failed after the response stream was already gone.This catches those late failures, ignores expected abort-driven errors when the request signal is aborted, and keeps non-abort failures logged instead of surfacing as process-level unhandled rejections. It also guards late stream writes and closes after abort.
I added regression coverage for the abort path, late writes after abort, and the normal response path. The focused adapter test passes, the full test suite passes 33/33, and build, TypeScript, and changeset status are clean.
Fixes #128