Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
dferber90
reviewed
May 6, 2026
| const flagsClients = new Map<string | undefined, FlagsClient>(); | ||
|
|
||
| function getOrCreateClient(sdkKey: string): FlagsClient { | ||
| function getOrCreateClient(sdkKey?: string): FlagsClient { |
Collaborator
There was a problem hiding this comment.
It's non-obvious that this will now also work for undefined (the OIDC use case).
Suggested change
| function getOrCreateClient(sdkKey?: string): FlagsClient { | |
| /** | |
| * Ensures we only ever create a single client per SDK Key | |
| * | |
| * When undefined is passed, due to OIDC being used, then we return a single client too. | |
| **/ | |
| function getOrCreateClient(sdkKey?: string): FlagsClient { |
Collaborator
There was a problem hiding this comment.
createVercelAdapter arg needs to be optional, such that it can default to the oidc one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.