Repository navigation
Fix ReDoS in numeric option value detection - #80
Open
Hashim1999164 wants to merge 1 commit into
Open
Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Replace the nested digit regex with an equivalent pattern that does not backtrack on long non matching input. Keeps negative and decimal number option values working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70
The previous pattern used overlapping optional digit runs with a lookahead, which backtracks badly on long non matching strings that start with a dash. That path runs for every option value that begins with
-, including String options, so a crafted argv entry can stall parsing.This switches to an equivalent check that accepts the same shapes (optional leading dash, digits, optional fractional part with at least one digit) without that nested ambiguity. Existing negative number option parsing still works, and a regression test covers a long non numeric value completing quickly.